-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Introducing... TailPipe! #29
Conversation
It might be a show stopper to the approach. Did you check if you could somehow tune up flushing or buffering behavior for those opened file(s) to ensure that stuff is dumped quickly after it is output by the process? or could you just check if that is the case and may be the reading process just is not informed/can't read it for some time/some reason? |
Fixed-- I was using write without flush to see what happens ;) |
Besides, its in the history
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
===========================================
+ Coverage 36.36% 47.97% +11.61%
===========================================
Files 1 1
Lines 187 198 +11
Branches 32 33 +1
===========================================
+ Hits 68 95 +27
+ Misses 117 101 -16
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Fixes: #10 |
TailPipe is nearly a drop-in replacement for TeeStream, but rather than "splitting the stream" we "tail -f" the stdout and stderr files as they are written.
BUG: should be streaming stdout and stderr, but instead we don't get output until the process ends.
Fixes: #27
Fixes #26
Fixes #25
Fixes #21
Fixes #10