Enh schema enforcer #243
Draft
Enh schema enforcer #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 5 5
Lines 749 749
Branches 95 95
=======================================
Hits 705 705
Misses 26 26
Partials 18 18 ☔ View full report in Codecov by Sentry. |
|
per conversation -- no need for overcomplicating, just make a test to compare to a list of specific values (being sorted) |
asmacdo
force-pushed
the
enh-schema-enforcer
branch
from
7e0b457 to
722c5d8
Compare
Adds a test that both:
- ensures that LS_FIELD_CHOICES represents all info.json fields
- ensure that info.json fields have not changed (which would require a
version bump, and a change to the field transformations)
there was no order previously, so might as well be alphabetized
asmacdo
force-pushed
the
enh-schema-enforcer
branch
from
722c5d8 to
75003f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on #241, originally to determine the list of fields that are filterable, but that is a secondary bonus, so I've separated this work into a separate PR.
By running duct, and flattening the output info.json we can guarantee that the info.json field list has not changed. When it does, this test will fail, and can help us to remember to bump the schema version.
Additionally, this tests that LS_FIELD_CHOICES is accurate and contains all the field choices (currently we are missing a couple)