Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --eval-filter #241

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Add --eval-filter #241

merged 7 commits into from
Feb 19, 2025

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Feb 7, 2025

Fixes: #239

  • Add tests
  • Investigate is _flatten_dict copy sufficient, or do we need deep_copy

_flatten_dict flattens the info dict, so we can eval-filter even parts that are not in execution_summary. Additionally, it creates a copy, so no need to .copy()

@asmacdo asmacdo added the semver-minor Increment the minor version when merged label Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (c575c80) to head (62e3a8c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   94.07%   94.12%   +0.04%     
==========================================
  Files           5        5              
  Lines         743      749       +6     
  Branches       94       95       +1     
==========================================
+ Hits          699      705       +6     
  Misses         26       26              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo asmacdo marked this pull request as ready for review February 9, 2025 19:14
@asmacdo asmacdo merged commit b7daaec into con:main Feb 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls: add option to filter entries -e|-eval-filter PYTHON_EXPR
2 participants