Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log files if interrupted via Ctrl-C #235

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

yarikoptic
Copy link
Member

This is not how it should be! it would depend on when it is interrupted and what was the actual process return code. Immediate usecase is my impatience with current implementation still waiting whenever command such as "ls" is done already.

Then when I interrupt with Ctrl-C we should still dump all the results and proceed to treat on how we would treat if command failed or not. It would also relate to

so if Ctrl-C the child process -- it is non-0 exit, and we would treat as "failed run".

So we should add it more smartly than what I did here

This is not how it should be!  it would depend on when it is interrupted and
what was the actual process return code.  Immediate usecase is my impatience
with current implementation still waiting whenever command such as  "ls" is
done already.

Then when I interrupt with Ctrl-C we should still dump all the results and
proceed to treat on how we would treat if command failed or not.  It would also
relate to

- #184

so if Ctrl-C the child process -- it is non-0 exit, and we would treat as
"failed run".

So we should add it more smartly than what I did here
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 14 lines in your changes missing coverage. Please review.

Project coverage is 94.68%. Comparing base (dfc3e4d) to head (34cf27f).

Files with missing lines Patch % Lines
src/con_duct/__main__.py 75.86% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   95.42%   94.68%   -0.74%     
==========================================
  Files           4        4              
  Lines         634      640       +6     
  Branches       72       72              
==========================================
+ Hits          605      606       +1     
- Misses         15       20       +5     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant