Test abandoning parent #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
force-pushed
the
test-abandoning-parent
branch
from
1845987 to
02ef9b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 95.89% 95.42% -0.48%
==========================================
Files 4 4
Lines 634 634
Branches 72 72
==========================================
- Hits 608 605 -3
- Misses 13 15 +2
- Partials 13 14 +1 ☔ View full report in Codecov by Sentry. |
|
pypy test failure is not related and will be fixed by #233 |
Just check that we have the correct number of processes Fixes con#44
Each invocation of pstree adds extra pids, which throws off the pid count
It seems like whats happening here is that if there are sufficiently many child processes to launch, duct does not collect a sample while the PID is still running. So we can increase the sleep time to avoid the problem for now.
asmacdo
force-pushed
the
test-abandoning-parent
branch
from
0d2795c to
43b8bf5
Compare
yarikoptic
reviewed
Jan 15, 2025
yarikoptic
reviewed
Jan 15, 2025
Co-authored-by: Yaroslav Halchenko <[email protected]>
yarikoptic
reviewed
Jan 22, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Passes, but ONLY when sleep is 0.1, longer periods result in too many PIDs??Fixes #44