Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At the end report absolute peak memory (may be with % if really like it) #49

Closed
yarikoptic opened this issue Jun 7, 2024 · 3 comments
Closed

Comments

@yarikoptic
Copy link
Member

ATM I see

❯ duct -- ./test_script.py --duration 3 --memory-size=1000
duct is executing ./test_script.py --duration 3 --memory-size=1000...
Log files will be written to .duct/logs/2024.06.06T23.20.47-1211148_
this is of test of STDERR
this is of test of STDOUT
Test completed. Consumed 1000 MB for 3 seconds with CPU load factor 10000.

Exit Code: 0
Command: ./test_script.py --duration 3 --memory-size=1000
Log files location: .duct/logs/2024.06.06T23.20.47-1211148_
Wall Clock Time: 3.3275320529937744
Memory Peak Usage: 0.0%
CPU Peak Usage: 104.0%
duct -- ./test_script.py --duration 3 --memory-size=1000  4.18s user 2.58s system 197% cpu 3.428 total

which is odd -- not sure what 0.0% it is reporting given that 1GB was requested.

@asmacdo
Copy link
Member

asmacdo commented Jun 7, 2024

I'm happy to switch to absolute amount rather than %, I only used % because thats what smon does https://github.com/brainlife/abcd-spec/blob/master/hooks/smon#L151

@asmacdo
Copy link
Member

asmacdo commented Jun 7, 2024

Fixed by #54

@asmacdo asmacdo closed this as completed Jun 7, 2024
@asmacdo
Copy link
Member

asmacdo commented Jun 7, 2024

duct ./test_script.py --duration 3 --memory-size=1000 
duct is executing ./test_script.py --duration 3 --memory-size=1000...
Log files will be written to .duct/logs/2024.06.07T11.21.48-553879_
this is of test of STDERR
this is of test of STDOUT
Test completed. Consumed 1000 MB for 3 seconds with CPU load factor 10000.

Exit Code: 0
Command: ./test_script.py --duration 3 --memory-size=1000
Log files location: .duct/logs/2024.06.07T11.21.48-553879_
Wall Clock Time: 3.376 sec
Memory Peak Usage: 3.1%
CPU Peak Usage: 193.0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants