-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior when runtime < sample-interval #36
Comments
+1 |
When running Ill fix this with docs for now, lmk if you want some other behavior. |
I want behavior which makes sense for a user. IMHO it should be
|
another fresh sample with current version of #37 : full run/output❯ duct ls
duct is executing ls...
Log files will be written to .duct/logs/2024.06.04T16.45.28-850256_
CONTRIBUTING.rst
__pycache__
pyproject.toml
README.md
setup.cfg
smoke-tests.sh
src
test
test_logs.py
test_script.py
tox.ini
venvs
Exit Code: 0
Command: ls
Log files location: .duct/logs/2024.06.04T16.45.28-850256_
Wall Clock Time: 2.954258918762207
Memory Peak Usage: unknown%
CPU Peak Usage: unknown% so it gives |
1. No need to wait on join() the monitoring thread, it is safely killed when duct process exits. 2. pass when ps fails (because inner process has finished) 3. Collect the first sample immediately rather than waiting for <sample-interval> Fixes con#36
Leaving out join() isn't ideal, the thread ends up in a race condition with test cleanup Related: con#36
using
version
so it virtually takes no time to do
ls
but with duct:over a second.
The text was updated successfully, but these errors were encountered: