Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicons to match the cool new mark #7

Open
danielpcox opened this issue Jul 4, 2019 · 7 comments
Open

Update favicons to match the cool new mark #7

danielpcox opened this issue Jul 4, 2019 · 7 comments

Comments

@danielpcox
Copy link
Contributor

No description provided.

@shanberg
Copy link
Collaborator

@danielpcox Can you tell what favicon folder the new icons are supposed to go in? I see favicons in three different folders in the app...

@shanberg
Copy link
Collaborator

Here's a zip of all the icons I've exported, if you can figure out the right place to drop them.

favicon.zip

@danielpcox
Copy link
Contributor Author

danielpcox commented Jul 13, 2019

I just followed the pattern online I found for favicons, but I think the way this works is that (except for favicon.ico), all of them can go anywhere, and then they get linked directly with a <link> tag. I thought they were all in content/static/images/favicons?

The links:
image

@danielpcox
Copy link
Contributor Author

I also don't know if these are all necessary. I found a site online that I could hand an image, and it spit back all of the sizes, plus all the link tags.

@danielpcox
Copy link
Contributor Author

This is the site: https://www.favicon-generator.org

@danielpcox
Copy link
Contributor Author

Oh, I just opened your bundle, and I see that you've already broken them out. I'll try dumping them in and ensuring the links work.

@shanberg
Copy link
Collaborator

shanberg commented Oct 20, 2019

@danielpcox This is finished, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants