Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dark mode optional for those with it turned on system-wide #5

Open
danielpcox opened this issue Jul 4, 2019 · 1 comment
Open

Make dark mode optional for those with it turned on system-wide #5

danielpcox opened this issue Jul 4, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danielpcox
Copy link
Contributor

No description provided.

@shanberg shanberg added the good first issue Good for newcomers label Jul 13, 2019
@shanberg
Copy link
Collaborator

The Dark Mode styles are currently set in themes/static/css/main.css, using the prefers-color-scheme media query to activate or deactivate a block of CSS Custom Properties used to style the site.

Toggling the theme will likely require removing that media query and reimplementing the theme switch as a javascript-controlled CSS import, and then using prefers-color-scheme to set a default color scheme where we can tell what the user prefers.

Saving user preference could be done with a cookie or local storage, but that isn't my area of expertise.

@shanberg shanberg added the help wanted Extra attention is needed label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielpcox @shanberg