Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect a series of broken files. #32

Open
rwest opened this issue Jul 17, 2019 · 1 comment
Open

Collect a series of broken files. #32

rwest opened this issue Jul 17, 2019 · 1 comment

Comments

@rwest
Copy link
Member

rwest commented Jul 17, 2019

To help us figure out if we're doing the right thing. We need a bunch of examples.

@rwest
Copy link
Member Author

rwest commented Jan 14, 2020

For now these are going in https://github.com/comocheng/ChemCheck/tree/master/ChemCheck/media/examples

I have contributed a bunch which have syntax errors etc., from published models.

We should add examples of "bad chemistry". Two more categories:

  • can be parsed but fail cantera validation like duplicates that sum to negative rate coefficients
  • validate OK, but chemistry is wrong, like super-fast reverse rate coefficients, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant