Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to update Filebrowser #929

Open
2 tasks
ridvan-cln opened this issue Dec 19, 2024 · 5 comments
Open
2 tasks

Ability to update Filebrowser #929

ridvan-cln opened this issue Dec 19, 2024 · 5 comments
Labels
investigation We are looking into it

Comments

@ridvan-cln
Copy link

βœ… Have you read and understood the above guidelines?

yes

πŸ“œ What is the name of the script you are using?

Filebrowser

πŸ“‚ What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/filebrowser.sh)"

πŸ“ Provide a clear and concise description of the issue.

Hi,
first of all thanks for all the effort, these scripts are saving a lot of time for all of us.

Is it possible to update the script for Filebrowser so that it has the ability to update the app, like with most other scripts?

βš™οΈ What settings are you using?

  • Default Settings
  • Advanced Settings

πŸ–₯️ Which Linux distribution are you using?

Debian 12

πŸ”„ Steps to reproduce the issue.

...

❌ Paste the full error output (if available).

...

πŸ–ΌοΈ Additional context (optional).

No response

tjcomserv added a commit to tjcomserv/ProxmoxVE_HS that referenced this issue Dec 20, 2024
Add an "upgrade" option and change "uninstall" to "remove".
The upgrade option, just allows the script to continue installing the latest version.

This is in response to:
community-scripts#929
@michelroegl-brunner
Copy link
Member

Thanks for your effort, but you made the pull request against you own repo. On the other hand i had a look on your code and it dose not do anything updatewise. It just dose a echo command.

@MickLesk we should probably rebuild it entierly to fit the new system instead of patching that?

@michelroegl-brunner michelroegl-brunner added the investigation We are looking into it label Dec 20, 2024
@MickLesk
Copy link
Member

Not so easy, its not an LXC Script. You can execute this in all LXCs

@MickLesk
Copy link
Member

Can you test it?

 bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/misc/filebrowser.sh)"

@ridvan-cln
Copy link
Author

ridvan-cln commented Dec 21, 2024

Just tried, the script went through successful, but the running version is still the old one. Do i need to restart the service maybe?

Edit:
Restarting the service solved the issue, maybe you can add that to the script.
Thx a lot!

@MickLesk
Copy link
Member

Ok, i Update the Script on monday and create an pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation We are looking into it
Projects
None yet
Development

No branches or pull requests

3 participants