Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: upgrade all the CWL v1.0 conformance tests and confirm the results #87

Closed
mr-c opened this issue Nov 15, 2021 · 5 comments
Closed

Comments

@mr-c
Copy link
Member

mr-c commented Nov 15, 2021

No description provided.

@mr-c
Copy link
Member Author

mr-c commented Nov 15, 2021

I did this manually, and with #90 and #88 merged, this works for v1.0 to v1.1

@jdidion
Copy link

jdidion commented Dec 4, 2021

Please also test on mixed-versions tests, e.g. https://github.com/common-workflow-language/cwl-v1.2/blob/1.2.1_proposed/tests/mixed-versions/wf-v12.cwl

I get the following error when trying with the current release version:

Processing wf-v12.cwl
Unsupported cwlVersion: v1.2
Traceback (most recent call last):
  File "/Users/jdidion/.pyenv/versions/cwltool/bin/cwl-upgrader", line 11, in <module>
    sys.exit(main())
  File "/Users/jdidion/.pyenv/versions/3.6.14/envs/cwltool/lib/python3.6/site-packages/cwlupgrader/main.py", line 59, in main
    return run(parse_args(args))
  File "/Users/jdidion/.pyenv/versions/3.6.14/envs/cwltool/lib/python3.6/site-packages/cwlupgrader/main.py", line 80, in run
    document, args.v1_only, args.v1_1_only, args.dir, imports
  File "/Users/jdidion/.pyenv/versions/3.6.14/envs/cwltool/lib/python3.6/site-packages/cwlupgrader/main.py", line 118, in upgrade_document
    process_imports(document, imports, inner_updater, output_dir)
UnboundLocalError: local variable 'inner_updater' referenced before assignment

@tetron
Copy link
Member

tetron commented Dec 6, 2021

This should be fixed in main, need to make a new release.

@mr-c
Copy link
Member Author

mr-c commented Dec 6, 2021

@tetron Thanks for the reminder, I'll make one right after I finish #92

@mr-c
Copy link
Member Author

mr-c commented Dec 14, 2023

fixed in #139

@mr-c mr-c closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants