Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncle button AKA "mark as failed" #248

Open
dreeves opened this issue Aug 20, 2018 · 1 comment
Open

Uncle button AKA "mark as failed" #248

dreeves opened this issue Aug 20, 2018 · 1 comment
Labels
help wanted RFE Request For Enhancement AKA feature request UVI User-Visible Improvement

Comments

@dreeves
Copy link
Contributor

dreeves commented Aug 20, 2018

Just as there's a way to click "mark as X% complete" there should also be a way to click "mark as failed" to make the promise be scored as 0% complete and show up colored black the same as completed promises and sorted the same as completed promises. (Or maybe a subtly different color, but that's a separate issue -- #247.)

@dreeves dreeves added RFE Request For Enhancement AKA feature request help wanted UVI User-Visible Improvement labels Aug 20, 2018
@patrickvossler18
Copy link

Hello, I'd like to help with this issue. But I have a few questions about the task:

  1. I think setting up the api endpoint to mark the promise as 0% complete is pretty similar to the mark as complete endpoint. My main questions are:

    • Should we mark tfin as the time when the task is marked as failed or should we have a separate tfail?
    • In the promises model, credit is determined by the parseCredit function which only handles incomplete tasks and completed tasks. Should we add a failed boolean to the promise to handle parsing credit for failed tasks?
  2. In terms of UI, is there any preference for where the mark as failed button should go?

    • I've implemented a simple mark as failed button with handlebars but should the frontend part be put on hold until the react transition is finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted RFE Request For Enhancement AKA feature request UVI User-Visible Improvement
Projects
None yet
Development

No branches or pull requests

2 participants