Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Slack bot to compose Commits.to URLs #240

Open
dreeves opened this issue Aug 1, 2018 · 5 comments
Open

Make a Slack bot to compose Commits.to URLs #240

dreeves opened this issue Aug 1, 2018 · 5 comments
Labels
RFE Request For Enhancement AKA feature request UVI User-Visible Improvement

Comments

@dreeves
Copy link
Contributor

dreeves commented Aug 1, 2018

we could totally make a simple slack bot that provides a slash command to create a commitment and generate the commits.to URL. it’s almost superfluous but could trim off a bit of friction i guess. or add discoverability since you see what apps are connected and might check what commands they provide.

this is not high priority but luke wanted to work on it...

@dreeves dreeves added RFE Request For Enhancement AKA feature request help wanted good first issue UVI User-Visible Improvement labels Aug 1, 2018
@echodaniel
Copy link

Since it’s not high priority, mind if I give it a shot? Also, is there a certain language you need it written in? I was going to use Python since that’s what I’m most familiar with.

echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 12, 2018
Slack bot for creating commits.

Reference commitsto#240
echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 12, 2018
Code to make basic Slack Bot. See commitsto#240

Still have to add features.
@echodaniel
Copy link

@chrisbutler created a pull request (for the base code) on the fork on my account if you'd like to check it out. Let me know what you think - working on my cell for the next week or so until I get my laptop in.

@chrisbutler
Copy link
Member

hey @echodaniel, thanks for taking this on!

i know almost nothing about python (😞) but i'm definitely interested in looking at and understanding this.

does this slackbot code run independently of the main commits.to repo/codebase? i'm wondering if maybe we should have a separate repo for all slackbot work. thoughts?

@echodaniel
Copy link

Hey @chrisbutler, you’re welcome! I’ve been waiting for a project that I can take on with regards to commits.to!

In answer to your question, yes, it should run in a virtual environment separate from the rest of the production code, BUT I definitely like the idea of a separate repo for all the slackbot code, especially during development and testing.

@echodaniel
Copy link

echodaniel commented Aug 16, 2018

@chrisbutler I’m thinking of designing it in such a way that (one way we could go is) all we’d need to do is give it / commands to test out different commits. So an example would be (within slack) if someone wanted to test a commit they could simply do

“@ commitbot /parse_this_promise”

And the bot would (maybe, this might take more work than I’m realizing) automatically create that commit, using that persons username as long as they already have an account set up and both names match. Or it might just create it as CommitBot. I’ll have to add features and test them out as I go.

echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 23, 2018
* Create CommitBot.py

Code to make basic Slack Bot. See commitsto#240

Still have to add features.

* Update CommitBot.py
echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 23, 2018
Slack bot for creating commits.

Reference commitsto#240
echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 23, 2018
* Create CommitBot.py

Code to make basic Slack Bot. See commitsto#240

Still have to add features.

* Update CommitBot.py
echodaniel added a commit to echodaniel/commits.to that referenced this issue Aug 23, 2018
Making additional edits for commitsto#240
echodaniel referenced this issue in echodaniel/commits.to Aug 27, 2018
Added more stuff. Updated commands it can take, added a variable to parse a URL (or at least remind me to make one) that might break aforementioned commands.
echodaniel added a commit to echodaniel/commits.to that referenced this issue Sep 12, 2018
Reference commitsto#240

Updated MENTION_REGEX so it will match allowed URL characters (and only those in allowable); so people don’t get into bad habits early.

Added two different options for making commits with the bot. The statement /iwill or the statement /commitsto. Because, well, why not?

It is way too early and I’m not used to the time change and the word commit is reminding me of the old movie Rocketman.
echodaniel referenced this issue in echodaniel/commits.to Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Request For Enhancement AKA feature request UVI User-Visible Improvement
Projects
None yet
Development

No branches or pull requests

3 participants