Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Building footprint ID" and "UPRN" need source type and source link #1176

Closed
Tracked by #1165
mdsimpson42 opened this issue Jun 6, 2023 · 1 comment
Closed
Tracked by #1165

Comments

@mdsimpson42
Copy link
Contributor

mdsimpson42 commented Jun 6, 2023

In the Location Category, we have two fields:

  • Building footprint ID
  • UPRN(s)

Both of these fields are not editable, so the user cannot change them. They are presumably inferred automatically from another dataset.

image

  1. Given that they cannot be edited, does it make sense to include the "source type" and "source link" fields? Surely the source is fixed (to whatever data source they were loaded from).

  2. How is a user supposed to verify this information?


We could provide links to the relevant data sources, in the same way as we have done with OSM IDs (issue #1148). But this requires there to be an accessible URL that we can use to access that data on that specific building.

If we can do that, then we could add a verify button to each field, along with the source link, but it would be bespoke and not the generic source type/link that is used elsewhere on the site. (And it wouldn't be editable as the field aren't editable).

@mdsimpson42
Copy link
Contributor Author

I have added source links to each of these fields. The idea was to create a static, clickable link, since these IDs are automatically derived and cannot be edited.

However, it was pointed out that this is not consistent with the rest of the site. But the links on the rest of the site currently don't allow you to easily click them, so we may need to change how links work. For example, we could try to add a link (🔗) button to the right-hand edge of each URL field, which would allow the user to click the link easily (if a link is present).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant