-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMMUNITIES SECTION- prevent likes for individual domestic buildings- only allow 'domestic typology' likes #18
COMMUNITIES SECTION- prevent likes for individual domestic buildings- only allow 'domestic typology' likes #18
Comments
Is it really needed? Is it maybe duplicating landuse data already asking about use as dwellings? |
@matkoniecz just let me know if this is too much within the time you have. Remove yellow box saying new feature Add blue box at the top of the page saying 'Please add information on how well you think buildings work and how they are used, by clicking first on a building, then on the 'Edit' button, and then on the relevant box (Click boxes again if you need to remove data you have added). Then add the following questions Then put the map button in here If the answer is 'a home' then open up the following question: If the answer is 'another type of building?' then open up the following 2 questions: Change the key so that it visualises only data relating to the 'Do you think this type of building contributes to the city?' question for both domestic and non-domestic buildings |
I will look into it at Monday |
many thanks |
@polly64 Would it be OK to hide (remove from view and visualization) things specific to home/non-home answer? Without deleting them? This way someone flipping between home and non-home will not delete other data and this way it will be also a bit easier to implement. This way data would be still visible in database downloads and object history. |
@matkoniecz yes could do for the moment- my concern would be others could then visualise this in the longer term using open footprints. But ok for short term fix. Could you add at the same time on Phase 2 planning list so we don't forget? |
Note that it will not cover sheds/garages etc (not sure is "domestic" covering them) I added also extra functionality to hide existing likes from map. Before: After (note how like visualisation is coming back after marking it as non-domestic): Do you maybe want map visualisation which buildings are marked as homes or nonhomes and which are not?
Can it be like in gif above? (such split is annoying from a technical side) |
@matkoniecz not sure quite understand your last point- main visualisation we need is for liked typologies. Domestic and non domestic building option for visualisation on key should really fall in Land Use section . I'm in London today but can also have a meeting tomorrow if any help |
I can add such visualisation (also in land use section), maybe temporarily, if that would be useful in filling this data. This part is relatively easy (would take about 20 minutes for yes/no visualisation of a single field) and may help to spot buildings with missing data. |
@matkoniecz sounds great |
is it supposed to replace "Do you think this type of building is generally worth keeping?" question? |
@matkoniecz yes |
@polly64 And existing data should be kept, just name should be changed? |
@matkoniecz yes |
What you mean by that? Not displaying like counts on the map for domestic buildings? Not displaying like count at all? I see later
|
@matkoniecz never displaying 'like' counts for domestic buildings only typology 'like' counts |
Should we display like count for public buildings? If we display typology like count for specific buildings on the map then it does not seem to be conceptually different. |
I will move it to a separate issue as it is a bit trickier and already bunch of things is being changed. |
Changes deployed to https://cl-staging.uksouth.cloudapp.azure.com/edit/community/2481763 What is missing: should we display like counts for public buildings anywhere? Should we remove it from the map? Not sure how well general public will distinguish liking type of building and specific building, especially if individual specific buildings will be painted based on rating of building type. "with an option to 'click all'" " Migrate all 'like' data to like typology' for saftety and then work with PH to identify non-dom buildings which can be re-liked before too many more entries are added *" - is it still needed with display blocked for buildings marked as domestic and ones with unknown state? |
@matkoniecz shall we have a quick chat tomorrow anytime between 9 am and 11 am? |
@matkoniecz I agree the difference is slim maybe we can talk about this. I think we need to remove the thumbs up and word like from the key to help this. Just need to move to more anonymity. But I do think if you point to my house and say 'Do you like this house?' or if you say ' Do you like this type of house?' then I'd be less offended if they didn't colour my house and coloured the one next door Btw where on staging need to just remove the 'is' in 'Do you think this type of building is contributes to the city? |
@polly64 That would work for me! |
@matkoniecz let's go for 9am tomorrow |
Work from home does not count as office and does not make building non-domestic. |
After all: we need domestic (yellow)/no-domestic (red)/mixed (orange)/not yet declared (no coloured) map. And we need mixed domestic and domestic use status. |
@matkoniecz really getting there but think a few things need tweaking
For section 2)
For section 1)
(keep the following as now
For section 2)
|
Hide complete like me for specific buildings, including map layer |
this should use standard yes button for community views |
@matkoniecz @mdsimpson42 Mateusz these changes will all be on Colouing core repository from now on won't they? |
@polly64 I expect that I will complete it tomorrow, though not sure how much time will be from opening pull request and merging. |
@matkoniecz @fallipalaiologou @mdsimpson42 This is quite a priority for planning/ user-well being as we hopefully will soon have a lot of local societies adding data
@matkoniecz depending on how much time you have left this is something we need to look at though (to minimise time) only starred items . Otherwise could you let @mdsimpson42 know, as one for us to prioritise this week
The Planning section is linked to the Community section where we are allowing people to 'like' buildings including homes. We need to block this and only allow them to like domestic typologies not individual buildings. (They can still like like non-domestic individual buildings and typologies in the same way as now.) This is because citizens have a different relationship with domestic buildings - emotional/personal attachment- than non-dom, and asking people to 'like' individual's homes will i realise cause problems in future as some homes will end up with far fewer likes than others. This doesn't matter for non-dom. We also need to change the 'Like ' key also to only visualise liked typologies. so the key would read ' Like this type of building?'
I have starred items below which area priority
@matkoniecz could you do this one so i can start classifying them ready to move domestic ones?
The text was updated successfully, but these errors were encountered: