Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove joda.time from cube module #138

Closed
natan-cox-cognizone opened this issue Aug 30, 2022 · 1 comment · Fixed by #140
Closed

remove joda.time from cube module #138

natan-cox-cognizone opened this issue Aug 30, 2022 · 1 comment · Fixed by #140
Assignees
@natan-cox-cognizone
Labels
bug Something isn't working cleanup Something needs some TLC subtask splitting into tasks when enhancement is too big

Comments

@natan-cox-cognizone
Copy link
Collaborator

Joda time can be replaced with standard Java libraries.

Joda time also seems to have some issues with some dates like in this snippet

ISODateTimeFormat.dateTimeParser().parseDateTime("1916-05-01")
@natan-cox-cognizone natan-cox-cognizone self-assigned this Aug 30, 2022
@natan-cox-cognizone natan-cox-cognizone added bug Something isn't working enhancement New feature or request cleanup Something needs some TLC and removed enhancement New feature or request labels Aug 30, 2022
natan-cox-cognizone added a commit that referenced this issue Aug 30, 2022
@natan-cox-cognizone
fix #138 removed joda time from cube module
917b1fb
@natan-cox-cognizone natan-cox-cognizone added the subtask splitting into tasks when enhancement is too big label Aug 30, 2022
@natan-cox-cognizone
Copy link
Collaborator Author

see also #15 phase out joda time

@natan-cox-cognizone natan-cox-cognizone linked a pull request Aug 30, 2022 that will close this issue
138 remove jodatime from cube module #140
Merged
natan-cox-cognizone added a commit that referenced this issue Aug 30, 2022
@natan-cox-cognizone
138 remove jodatime from cube module (#140)
1c5a5cd 
* fix #138 removed joda time from cube module

* fix #139 use sorted maps in ConversionProfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natan-cox-cognizone natan-cox-cognizone

Labels
bug Something isn't working cleanup Something needs some TLC subtask splitting into tasks when enhancement is too big
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

138 remove jodatime from cube module cognizone/asquare
1 participant
@natan-cox-cognizone