Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PhysicalDeviceMemoryProperties to return slices of proper sizes #10

Open
GabrielMajeri opened this issue Jun 22, 2018 · 1 comment
Open

Change PhysicalDeviceMemoryProperties to return slices of proper sizes #10

GabrielMajeri opened this issue Jun 22, 2018 · 1 comment

Comments

@GabrielMajeri
Copy link
Contributor

The PhysicalDeviceMemoryProperties struct has functions which allow the developer to get a slice of size VK_MAX_MEMORY_TYPES. The entries up to memory_type_count are valid, the ones after are invalid.

The Voodoo API should have only one function, memory_types, and it should return a slice of the correct size: &memory_types[..memory_type_count].
@c0gent
Copy link
Member

c0gent commented Jun 23, 2018

Agreed. I'll adjust this as soon as I can.

Please keep the suggestions coming. I won't have time to make these changes right away but having issues filed here is very helpful.

@GabrielMajeri GabrielMajeri mentioned this issue Jun 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c0gent @GabrielMajeri