Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Slash Menu Not Functioning in Alpha Editor #1130

Closed
John-Paul-Larkin opened this issue Oct 15, 2024 · 8 comments
Closed

Bugfix: Slash Menu Not Functioning in Alpha Editor #1130

John-Paul-Larkin opened this issue Oct 15, 2024 · 8 comments

Comments

@John-Paul-Larkin
Copy link
Member

Context

After merging PR #1068, the slash menu in the alpha editor stopped functioning. The issue appears to have originated from changes introduced in that PR.

Expected Behavior

When a user presses the "/" key, the slash menu options should be displayed on the screen. This functionality worked correctly prior to PR #1068.
Pull a commit prior to this PR to see how it should work.

Current Behavior

Currently, pressing the "/" key does not seem to trigger any action, and the slash menu does not appear.

Screenshots

Slash menu :
Slash menu

@PAVAN507-STAR
Copy link

Hii @John-Paul-Larkin.I would like to work on this issue.Can u assign me this issue?

@John-Paul-Larkin
Copy link
Member Author

Thanks @PAVAN507-STAR
I assigned you.

Copy link

Uh oh! @PAVAN507-STAR, the image you shared is missing helpful alt text. Check #1130 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@John-Paul-Larkin
Copy link
Member Author

hi @PAVAN507-STAR
How are you getting on with this issue?

@PAVAN507-STAR
Copy link

I’ve tried to reset the commit and see what happens but it seems multiple folders were deleted in the mentioned pr and some other pr’s too. So rn im trying to see if i can implement the feature without the deleted folders somehow ,btw do u have any idea what are the folders that got deleted but are required to implement the feature?

@John-Paul-Larkin
Copy link
Member Author

@PAVAN507-STAR
Unfortunately I do not. If you roll back to an older commit you will be able to see the implementation. Thanks.

@NiallJoeMaher
Copy link
Contributor

This one might be fixed in the design updates PR that is open. I haven't tested it but I saw from the code it looked promising.

@PAVAN507-STAR
Copy link

@NiallJoeMaher I have seen many folders like custom edit and some other folders are deleted so should i bring them back in this pr or were they deleted on purpose in some pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants