-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Error Boundary and Server-Side API Calls for Recent Bookmarks Sidebar #1097
Comments
Want to work on this one |
@HarshitT00 |
How to reproduce the error? |
@HarshitT00 |
myBookmarks: protectedProcedure.query(async ({ ctx }) => { should do anything else to reproduce error |
Uh oh! @HarshitT00, the image you shared is missing helpful alt text. Check #1097 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
Uh oh! @HarshitT00, the image you shared is missing helpful alt text. Check #1097 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
@HarshitT00 |
Yes, But I have made some changes in code to handle current situation in better way. If you want I can raise a PR |
Even better, thanks. Please put a WIP tag on the PR until Niall reviews this issue. |
@HarshitT00 I left a comment. I think we don't need all the changes but some of them are great. I'll close this issue but you can see the comment in your PR. If you fix up based on my comment I'll merge it (and get you some of those sweet Hacktoberfest points). |
Context
The Recent Bookmarks sidebar currently crashes the entire page if the API call fails. We need to improve the error handling so that the entire page is not affected by an API failure related to this component.
Expected Behavior
Screenshots
The text was updated successfully, but these errors were encountered: