Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 코드 리팩토링 #38

Open
5 tasks
hsik0225 opened this issue May 30, 2020 · 0 comments
Open
5 tasks

[BE] 코드 리팩토링 #38

hsik0225 opened this issue May 30, 2020 · 0 comments
Assignees
@hsik0225
Labels
BE Feature 새로운 기능 개발

Comments

@hsik0225
Copy link
Contributor

hsik0225 commented May 30, 2020 •
edited
Loading

리팩토링

  • 패키지 설계
  • 예외처리
  • 트랜잭션
  • 메소드 분리
  • 등 등..
@hsik0225 hsik0225 added BE Feature 새로운 기능 개발 labels May 30, 2020
@hsik0225 hsik0225 self-assigned this May 30, 2020
hsik0225 added a commit that referenced this issue May 30, 2020
@hsik0225
[#38] refactor: 패키지 구조 변경
e47681e 
- 도메인에 관련된 것들끼리 묶어서 패키지 구조 설계
계층별로 분류하니 기능이 다른 것들끼리 묶여 있어 찾아가기 불편했다

- DDD Start 최범균 패키지 참조
hsik0225 added a commit that referenced this issue May 30, 2020
@hsik0225
[#38] refactor: MainController에서 메소드 분리 및 Common 패키지 생성
2862f4a 
- MainController에서 Reservation기능을 다른 컨트롤러로 분리
- 공통으로 들어가야할 경우를 대비해서 Common 패키지 생성
hsik0225 added a commit that referenced this issue May 30, 2020
@hsik0225
[#38] feat: sendRedirect 추가
01d1354
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: ControllerAdvice 생성
a54884a
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] refacotr: 유효성 검증 validation으로 변경
6eed69d
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: 예약 날짜 validation 구현
27e70bc
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: inputMistakeException controllerAdivce에 추가
030ef57
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: 예외처리를 위한 클래스 생성
657fd7d 
- 예외 코드를 담은 enum클래스
- 예외 메세지를 보낼 클래스
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: ErrorResponse 구현
2f73a2c
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] feat: ErrorCode 구현
8752c78
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] refactor: 사용하지 않는 예외처리 제거 및 리다이렉트 경로 변경
96858b3
hsik0225 added a commit that referenced this issue Jun 4, 2020
@hsik0225
[#38] fix: limit 5 오류 수정
f420ad7
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 예외처리 메소드명 변경 및 속성 변경
34e18f6 
- InputMistake 에서 IlleggalReservationDate로 변경
- 속성 name, value, reasone, error 코드 추가
- springconfig 에서 config로 패키지명 변경
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: BindExceptio 예외처리 추가:
7be30ad
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: Guest, Budget validation 추가
d6a81dc
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] fix: httpOnly false로 변경
bd2702e
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: guest validate postive, digits 추가
29a225e
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: Budget validate 추가
0a0379a 
- postive
- 정수 판단
- highestPrice가 lowestPrice보다 더 큰가
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refacotr: config 폴더 common 안으로 이동
719be49
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refacotr: 사용하지 않는 RoomDAO 클래스 삭제
a66db0f
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refacotr: 호텔 방을 관리하는 Manager 클래스 생성
e6428bb 
- room에도 reservation 어디에도 속할 수 있는 메소드들을 관리하는
클래스가 필요하다고 느껴서 생성
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 영수증과 리뷰 정보를 보여주는 메소드를 ManagerDAO로 이동
e7a20c3
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: canReserve의 인자 변경
6f7dc59
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: common.utils 패키지 생성 및 JwtUtils를 이동
bb911de 
- 프로젝트 전체에서 사용하므로 common에 있는게 맞다고 판단
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 인터셉터에서 setAttribute 삭제
5bc3255 
- 인터셉터에서 토큰을 파싱하고 복호화 한 후 request에 담는건 맞지 않다고 판단. 그것은 컨트롤러의 역할이라고 생각하여 삭제.
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: 쿠키 예외처리 추가
04bc656
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: JWT Exception 클래스 생성:
f71f0d6
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refacotr: JwtException 클래스 삭제 및 jwt ㅇㅖ외처리
c511ef0 
- jwtException클래스가 이미 존재해서 삭제
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: JwtException ContollerAdvice에 추가:
3c855ff
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 중복되는 validation 로직 삭제
eeb24d4
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] fix: reservationService 빈 생성
d65a5b3 
- @service 어노테이션 추가:
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: ResponseCookie에서 그냥 쿠키로 변경
4a19263 
- FE에서 자꾸 오류 발생하여 변경:
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] feat: Reqeust Header와 Body를 보기 위한 RestTemplate 추가
b5f6925 
- 들어오는 헤더와 바디가 어떤 값인지 알 수 없어 에러를 잡을 수 없어 추가
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: restTemplate config 삭제
6beb765 
- 생각하던 설정이 아니라서 삭제
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: JasyptTest 클래스 삭제
92fe323
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 사용하지 않는 lombok 메소드 삭제
f9dde70
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: response reset 메소드 제거
5d72bb7
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor: 쿠키 리퀘스트 수정
243969b
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] fix: cookie return값 수정
6c9c01c
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] Test: 인터셉터 메소드 수정
e72c56a
hsik0225 added a commit that referenced this issue Jun 5, 2020
@hsik0225
[#38] refactor : debug=true 설정
c057481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsik0225 hsik0225

Labels
BE Feature 새로운 기능 개발
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsik0225