diff --git a/python/src/rules_engine/engine.py b/python/src/rules_engine/engine.py index 8b8df757..372d2750 100644 --- a/python/src/rules_engine/engine.py +++ b/python/src/rules_engine/engine.py @@ -517,7 +517,7 @@ def _calculate_balance_point_and_ua( stdev_pct_max: float = 0.10, max_stdev_pct_diff: float = 0.01, next_balance_point_sensitivity: float = 0.5, - ) -> None: + ) -> any: """ Calculates the estimated balance point and UA coefficient for the home, removing UA outliers based on a normalized standard diff --git a/python/tests/test_rules_engine/test_engine.py b/python/tests/test_rules_engine/test_engine.py index 5eee15d9..0ad9d2d0 100644 --- a/python/tests/test_rules_engine/test_engine.py +++ b/python/tests/test_rules_engine/test_engine.py @@ -117,7 +117,7 @@ def sample_processed_energy_bill_inputs_with_outlier() -> ( @pytest.fixture() -def sample_summary_inputs() -> HeatLoadInput: +def sample_heat_load_inputs() -> HeatLoadInput: heat_sys_efficiency = 0.88 living_area = 1000 @@ -316,9 +316,9 @@ def test_get_average_indoor_temperature(): assert engine.get_average_indoor_temperature(set_temp, setback, setback_hrs) == 66 -def test_bp_ua_estimates(sample_summary_inputs, sample_processed_energy_bill_inputs): +def test_bp_ua_estimates(sample_heat_load_inputs, sample_processed_energy_bill_inputs): home = engine.Home.calculate( - sample_summary_inputs, + sample_heat_load_inputs, sample_processed_energy_bill_inputs, dhw_input=None, initial_balance_point=58, @@ -335,10 +335,10 @@ def test_bp_ua_estimates(sample_summary_inputs, sample_processed_energy_bill_inp def test_bp_ua_with_outlier( - sample_summary_inputs, sample_processed_energy_bill_inputs_with_outlier + sample_heat_load_inputs, sample_processed_energy_bill_inputs_with_outlier ): home = engine.Home.calculate( - sample_summary_inputs, + sample_heat_load_inputs, sample_processed_energy_bill_inputs_with_outlier, dhw_input=None, initial_balance_point=58, @@ -417,12 +417,12 @@ def test_convert_to_intermediate_processed_energy_bills( def test_get_outputs_normalized( - sample_summary_inputs, + sample_heat_load_inputs, sample_temp_inputs, sample_normalized_processed_energy_bill_inputs, ): rules_engine_result = engine.get_outputs_normalized( - sample_summary_inputs, + sample_heat_load_inputs, None, sample_temp_inputs, sample_normalized_processed_energy_bill_inputs,