From b0ca442ba8991199362bad7e5c702c9731738ee9 Mon Sep 17 00:00:00 2001 From: Rasz_pl Date: Sun, 21 Apr 2024 06:53:19 +0200 Subject: [PATCH 1/3] Update core.js stop injecting junk into HTML element on load only settings used by CSS allowed --- js&css/extension/core.js | 124 +++++++++++++++++++++++++++++++++++---- 1 file changed, 111 insertions(+), 13 deletions(-) diff --git a/js&css/extension/core.js b/js&css/extension/core.js index e3aa4f87a..4fe8ff4ef 100644 --- a/js&css/extension/core.js +++ b/js&css/extension/core.js @@ -37,6 +37,103 @@ var extension = { } }; +// list of settings we inject into HTML element as attributes, used by CSS. +let htmlAttributes = [ + "activated", + "ads", + "always-show-progress-bar", + "bluelight", + "channel-compact-theme", + "channel-hide-featured-content", + "collapse-of-subscription-sections", + "columns", + "comments", + "comments-sidebar", + "comments-sidebar-left", + "comments-sidebar-simple", + "compactSpacing", + "description", + "embeddedHidePauseOverlay", + "embeddedHideShare", + "embeddedHideYoutubeLogo", + "header-hide-country-code", + "header-hide-right-buttons", + "header-improve-logo", + "header-position", + "header-transparent", + "hide-animated-thumbnails", + "hide-author-avatars", + "hide-clip-button", + "hide-comments-count", + "hide-date", + "hide-details", + "hide-dislike-button", + "hide-download-button", + "hide-footer", + "hide-gradient-bottom", + "hide-more-button", + "hide-playlist", + "hide-report-button", + "hide-save-button", + "hide-scroll-for-details", + "hide-share-button", + "hide-shorts-remixing", + "hide-sidebar", + "hide-thanks-button", + "hide-thumbnail-overlay", + "hide-video-title-fullScreen", + "hide-views-count", + "hide-voice-search-button", + "improvedtube-search", + "likes", + "livechat", + "mini-player-cursor", + "no-page-margin", + "player-autoplay-button", + "player-color", + "player-crop-chapter-titles", + "player-fit-to-win-button", + "player-hide-annotations", + "player-hide-cards", + "player-hide-endscreen", + "player-hide-skip-overlay", + "player-miniplayer-button", + "player-next-button", + "player-play-button", + "player-previous-button", + "player-remote-button", + "player-screen-button", + "player-settings-button", + "player-show-cards-on-mouse-hover", + "player-size", + "player-size", + "player-subtitles-button", + "player-transparent-background", + "player-view-button", + "player-volume-button", + "red-dislike-button", + "related-videos", + "remove-black-bars", + "remove-history-shorts", + "remove-home-page-shorts", + "remove-related-search-results", + "remove-shorts-reel-search-results", + "remove-subscriptions-shorts", + "remove-trending-shorts", + "schedule", + "scroll-bar", + "scroll-to-top", + "search-focus", + "sidebar-left", + "squared-user-images", + "subscribe", + "theme", + "thumbnails-hide", + "thumbnails-right", + "transcript", + "youtube-home-page", + "youtubeDetailButtons" +]; /*-------------------------------------------------------------- # CAMELIZE @@ -117,7 +214,7 @@ extension.events.trigger = async function (type, data) { /*-------------------------------------------------------------- # INJECT ---------------------------------------------------------------- - + --------------------------------------------------------------*/ extension.inject = function (paths, callback) { @@ -270,13 +367,15 @@ extension.storage.get = function (key) { extension.storage.listener = function () { chrome.storage.onChanged.addListener(function (changes) { - for (var key in changes) { - var value = changes[key].newValue, + for (const key in changes) { + let value = changes[key].newValue, camelized_key = extension.camelize(key); extension.storage.data[key] = value; - document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), value); + if (htmlAttributes.includes(key)) { + document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), value); + } if (typeof extension.features[camelized_key] === 'function') { extension.features[camelized_key](true); @@ -303,23 +402,22 @@ extension.storage.listener = function () { extension.storage.load = function (callback) { chrome.storage.local.get(function (items) { - for (var key in items) { - var value = items[key]; - - extension.storage.data[key] = value; - - document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), value); - } + extension.storage.data = items; extension.events.trigger('storage-loaded'); - extension.messages.send({ action: 'storage-loaded', storage: items }); + for (const key in items) { + if (htmlAttributes.includes(key)) { + document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), items[key]); + } + } + if (callback) { callback(extension.storage.data); } }); -}; \ No newline at end of file +}; From 4d846278da60bbc609fa11ad4112ce121a46c401 Mon Sep 17 00:00:00 2001 From: Rasz_pl Date: Sat, 27 Apr 2024 14:32:45 +0200 Subject: [PATCH 2/3] Update core.js wrong punctuation --- js&css/extension/core.js | 154 +++++++++++++++++++-------------------- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/js&css/extension/core.js b/js&css/extension/core.js index 4fe8ff4ef..7d7a872aa 100644 --- a/js&css/extension/core.js +++ b/js&css/extension/core.js @@ -41,97 +41,97 @@ var extension = { let htmlAttributes = [ "activated", "ads", - "always-show-progress-bar", + "always_show_progress_bar", "bluelight", - "channel-compact-theme", - "channel-hide-featured-content", - "collapse-of-subscription-sections", + "channel_compact_theme", + "channel_hide_featured_content", + "collapse_of_subscription_sections", "columns", "comments", - "comments-sidebar", - "comments-sidebar-left", - "comments-sidebar-simple", + "comments_sidebar", + "comments_sidebar_left", + "comments_sidebar_simple", "compactSpacing", "description", "embeddedHidePauseOverlay", "embeddedHideShare", "embeddedHideYoutubeLogo", - "header-hide-country-code", - "header-hide-right-buttons", - "header-improve-logo", - "header-position", - "header-transparent", - "hide-animated-thumbnails", - "hide-author-avatars", - "hide-clip-button", - "hide-comments-count", - "hide-date", - "hide-details", - "hide-dislike-button", - "hide-download-button", - "hide-footer", - "hide-gradient-bottom", - "hide-more-button", - "hide-playlist", - "hide-report-button", - "hide-save-button", - "hide-scroll-for-details", - "hide-share-button", - "hide-shorts-remixing", - "hide-sidebar", - "hide-thanks-button", - "hide-thumbnail-overlay", - "hide-video-title-fullScreen", - "hide-views-count", - "hide-voice-search-button", - "improvedtube-search", + "header_hide_country_code", + "header_hide_right_buttons", + "header_improve_logo", + "header_position", + "header_transparent", + "hide_animated_thumbnails", + "hide_author_avatars", + "hide_clip_button", + "hide_comments_count", + "hide_date", + "hide_details", + "hide_dislike_button", + "hide_download_button", + "hide_footer", + "hide_gradient_bottom", + "hide_more_button", + "hide_playlist", + "hide_report_button", + "hide_save_button", + "hide_scroll_for_details", + "hide_share_button", + "hide_shorts_remixing", + "hide_sidebar", + "hide_thanks_button", + "hide_thumbnail_overlay", + "hide_video_title_fullScreen", + "hide_views_count", + "hide_voice_search_button", + "improvedtube_search", "likes", "livechat", - "mini-player-cursor", - "no-page-margin", - "player-autoplay-button", - "player-color", - "player-crop-chapter-titles", - "player-fit-to-win-button", - "player-hide-annotations", - "player-hide-cards", - "player-hide-endscreen", - "player-hide-skip-overlay", - "player-miniplayer-button", - "player-next-button", - "player-play-button", - "player-previous-button", - "player-remote-button", - "player-screen-button", - "player-settings-button", - "player-show-cards-on-mouse-hover", - "player-size", - "player-size", - "player-subtitles-button", - "player-transparent-background", - "player-view-button", - "player-volume-button", - "red-dislike-button", - "related-videos", - "remove-black-bars", - "remove-history-shorts", - "remove-home-page-shorts", - "remove-related-search-results", - "remove-shorts-reel-search-results", - "remove-subscriptions-shorts", - "remove-trending-shorts", + "mini_player_cursor", + "no_page_margin", + "player_autoplay_button", + "player_color", + "player_crop_chapter_titles", + "player_fit_to_win_button", + "player_hide_annotations", + "player_hide_cards", + "player_hide_endscreen", + "player_hide_skip_overlay", + "player_miniplayer_button", + "player_next_button", + "player_play_button", + "player_previous_button", + "player_remote_button", + "player_screen_button", + "player_settings_button", + "player_show_cards_on_mouse_hover", + "player_size", + "player_size", + "player_subtitles_button", + "player_transparent_background", + "player_view_button", + "player_volume_button", + "red_dislike_button", + "related_videos", + "remove_black_bars", + "remove_history_shorts", + "remove_home_page_shorts", + "remove_related_search_results", + "remove_shorts_reel_search_results", + "remove_subscriptions_shorts", + "remove_trending_shorts", "schedule", - "scroll-bar", - "scroll-to-top", - "search-focus", - "sidebar-left", - "squared-user-images", + "scroll_bar", + "scroll_to_top", + "search_focus", + "sidebar_left", + "squared_user_images", "subscribe", "theme", - "thumbnails-hide", - "thumbnails-right", + "thumbnails_hide", + "thumbnails_right", "transcript", - "youtube-home-page", + "youtube_home_page", "youtubeDetailButtons" ]; From e23a37640fed1d1709e448dc8674e5899f338676 Mon Sep 17 00:00:00 2001 From: Rasz_pl Date: Thu, 9 May 2024 04:18:33 +0200 Subject: [PATCH 3/3] Update core.js updated --- js&css/extension/core.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/js&css/extension/core.js b/js&css/extension/core.js index adbaf7b27..77d413d39 100644 --- a/js&css/extension/core.js +++ b/js&css/extension/core.js @@ -411,7 +411,9 @@ extension.storage.load = function (callback) { } for (const key in items) { - document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), items[key]); + if (htmlAttributes.includes(key)) { + document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), items[key]); + } } extension.events.trigger('storage-loaded'); @@ -420,12 +422,6 @@ extension.storage.load = function (callback) { storage: items }); - for (const key in items) { - if (htmlAttributes.includes(key)) { - document.documentElement.setAttribute('it-' + key.replace(/_/g, '-'), items[key]); - } - } - if (callback) { callback(extension.storage.data); }