Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding missing ⏭️ for SKIPPED test output on command line and update SKIPPED with ❌ emoji #878

Closed
agentpoyo opened this issue Jul 21, 2021 · 9 comments
Assignees
Labels
emoji Add emojis to tests (milestone: https://github.com/cncf/cnf-testsuite/milestone/10) enhancement New feature or request good first issue Good for newcomers

Comments

@agentpoyo
Copy link
Collaborator

Describe the solution you'd like
There are SKIPPED tests missing the default ⏭️ emoji or have the ❌ during cnf-testsuite output on the command line. All tests that have the SKIPPED option should include this emoji to keep the output consistent.

Additional context
These are the current tests missing or have the wrong emoji, ex. ❌ instead of ⏭️ from a quick search and find:

src/tasks/workload/installability.cr:  "SKIPPED: Helm Deploy"
src/tasks/workload/configuration_lifecycle.cr:  "✖️  SKIPPED: immutable configmaps..."
src/tasks/platform/observability.cr:  "SKIPPED: Kube State Metrics"
src/tasks/platform/observability.cr:  "SKIPPED: Node Exporter"
src/tasks/platform/observability.cr:  "SKIPPED: Prometheus Adapter"
src/tasks/platform/observability.cr:  "SKIPPED: Metrics Server"
src/tasks/platform/platform.cr:  "SKIPPED: ClusterAPI Enabled"
src/tasks/platform/resilience.cr:  "SKIPPED: Node Failure"
@agentpoyo agentpoyo added enhancement New feature or request good first issue Good for newcomers emoji Add emojis to tests (milestone: https://github.com/cncf/cnf-testsuite/milestone/10) labels Jul 21, 2021
@lixuna lixuna added this to the Add emojis to test results milestone Jul 21, 2021
@srisatya12
Copy link

@agentpoyo I want to work on this issue.

@agentpoyo
Copy link
Collaborator Author

@agentpoyo I want to work on this issue.

Hello @SriSatyaT

Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide.

If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

@srisatya12
Copy link

@agentpoyo I want to work on this issue.

Hello @SriSatyaT

Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide.

If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

I tried to run the command "curl -s https://raw.githubusercontent.com/cncf/cnf-testsuite/main/curl_install.sh | bash" but there was no respond like any message in prompt I waited till 20 minutes and terminated and got this message. Should I proceed to next step or should I run this again.
Command Prompt 14-09-2021 21_21_20

@agentpoyo
Copy link
Collaborator Author

@agentpoyo I want to work on this issue.

Hello @SriSatyaT
Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide.
If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

I tried to run the command "curl -s https://raw.githubusercontent.com/cncf/cnf-testsuite/main/curl_install.sh | bash" but there was no respond like any message in prompt I waited till 20 minutes and terminated and got this message. Should I proceed to next step or should I run this again.

Hello @SriSatyaT ,

The cnf-testsuite doesn't run natively on the Windows Command Line. You can setup WSL (Windows Subsystem for Linux) to install the suite onto. But you'll need a bash prompt in order to successfully install the test suite.

Cheers,

-ap

@Qarthak
Copy link

Qarthak commented Sep 14, 2022

@agentpoyo I want to work on this issue

@HashNuke
Copy link
Collaborator

@Qarthak Hello Sarthak. Feel free to contribute by sending a PR.

If you haven’t tried/used the project before checkout the readme and see if that helps you setup the project. Let us know if you get stuck and we can help you get started.

You can ping any one of us mentioned in the previous comments for help.

@agentpoyo
Copy link
Collaborator Author

@Qarthak @HashNuke

Definitely review the code but I think this might of been addressed already during another issue feature where we cleaned up and reorganized the console output. But do feel free to review to see if any proper emoji handlers are missing or need correction. Thanks.

martin-mat added a commit to martin-mat/cnf-testsuite that referenced this issue Jan 10, 2024
agentpoyo added a commit that referenced this issue Jan 11, 2024
@martin-mat
Copy link
Collaborator

@agentpoyo I think after merging #1852 this issue can be closed.

@agentpoyo agentpoyo self-assigned this Jan 15, 2024
@agentpoyo
Copy link
Collaborator Author

agentpoyo commented Jan 15, 2024

Acceptance Criteria

  • Find or use existing K8s cluster
  • Setup cnf-testsuite using pre-built binary if available with updates or checkout source code and follow source installation
  • Setup CNF using example or sample CNF's
  • When I run the tests:
    • Helm Deploy
    • immutable configmaps
    • Kube State Metrics"
    • Node Exporter"
    • Prometheus Adapter"
    • Metrics Server"
    • ClusterAPI Enabled"
    • Node Failure"
      I should see the SKIPPED emoji ⏭️ when the test is SKIPPED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emoji Add emojis to tests (milestone: https://github.com/cncf/cnf-testsuite/milestone/10) enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

6 participants