add configuration steps to create a brew release #271
Conversation
Signed-off-by: Nima Kaviani <[email protected]>
| brews: | ||
| - name: idpbuilder | ||
| homepage: "https://cnoe.io" | ||
| repository: |
There was a problem hiding this comment.
Do we want the repository for this to be nimakaviani/homebrew-cnoe or is this for testing? I would imagine maybe we'd want to consider cnoe-io/tap as the repository. It does seem that other big projects like argocd follow the pattern of project/tap for example argo uses argoproj/tap based on documentation here https://docs.brew.sh/Taps#the-brew-tap-command
There was a problem hiding this comment.
ah, an oversight with the owner name. fixed, thanks!
agreed. tap is a better name. renamed the repo to publish to tap.
Signed-off-by: Nima Kaviani <[email protected]>
Signed-off-by: Nima Kaviani <[email protected]>
|
Is this still relevant? |
|
Adding idpbuilder to homebrew is definitely a plus but then the documentation should be updated |
|
LGTM. Approved. |
|
Can we go ahead and merge this PR ? Is it possible to test it (= GH Flow) to check what it is produced and to make a test to install it locally ? |
|
Fix the merge conflict and we can merge imo. As for testing it in a GH workflow, I am not sure tbh. Maybe open an issue and work on it separately? I do like the idea of installing it via home brew. |
As an action should run tonight when nightly tag will be created I will review tomorrow what happened and maybe create a ticket separately |
creates the homebrew formula for idpbuilder
Theoretically everything should work but kinda tricky to test this on the actual repo, since we need to cut a release. we can give it a go after it is reviewed and merged.