-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: createArgoApplication
does not support destination server.
#42
Comments
I am all for this. One limitation we need to be clear is that the roadie backend plugin does not allow specifying deployment cluster by name. i.e. it expects a URL. We can expand our spec but if we truly want to support ArgoCD deployment target, we really should allow for names. |
@nabuskey At this point we are expecting to support only Deployment Target by name. We are going by the assumption that target clusters are all configured and can be specified by name |
Hmmm in that case, we can't fix it here. We'll have to ask in the roadie repo. We should verify first though. Last I checked, it wasn't possible to specify by name. |
What i mean is it should support something like below if we can add that support in this repo. Let me try out, create an image and test. apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: argorollouts-dev
namespace: argocd
spec:
project: default
source:
chart: argo-rollouts
repoURL: https://argoproj.github.io/argo-helm
targetRevision: 2.37.7
helm:
releaseName: argorollouts-dev
destination:
name: 'dev-cluster'
namespace: argo-rollouts
syncPolicy:
automated:
selfHeal: true
syncOptions:
- CreateNamespace=true
|
The name part probably won't work. As far as I know, the roadie backend plugin we use does not support it. It's a great contribution opportunity imo. |
Thanks for the insights Manabu, I agree its a great contrib opp. I will see what i can do and i will also take your help. |
Have you searched for this feature request?
Problem Statement
Currently Backstage uses roadie's ArgoCD plugin which supports Destination Server. But
createArgoApplication
does not support destination server. This is required for multi cluster deployments. This code which invokes this plugin does not supportDestination
.Possible Solution
Currently Backstage uses roadie's ArgoCD plugin which supports Destination Server. But
createArgoApplication
does not support destination server. This is required for multi cluster deployments. This code which invokes this plugin does not supportDestination
. Appreciate if you can support this feature asap to multi cluster deployments from Backstage to Child clusters.Alternatives Considered
None.
The text was updated successfully, but these errors were encountered: