-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the cmake build to make use of Qt6 modern cmake features #207
Comments
I have created an implementation of this and can provide is soon as a PR. But I think this would also "modernize" quite a bit some other details of QuickQanava, and I wonder if that is acceptable? Things that could/should be changed:
|
Hi @emmenlau, thank for you detailled BR: using newest Qt6 features is a very good idea and a good move to clean the build system. If you are willing to maintain a Qt6 branch, I would be very happy to support your work and it would give our users (I know at least 4 commercial projects using QuickQanava) more time to prepare for change. I am OK with all of your points (except perhaps no using qrc, I've bad memories about that, perhaps specific to Qt5). I would even add:
|
Dear @cneben , thanks a lot for the thumbs up, sounds a good way forward! In the next two weeks we are completely booked with other projects, but afterwards I'm happy to share my progress and maintain it in a Qt 6 branch! |
Signed-off-by: cneben <[email protected]>
Remove top level QuickContainers directory (not idiomatic for CMake). quickcontainers is now fully integrated in QuickQanava source tree. Signed-off-by: cneben <[email protected]>
Signed-off-by: cneben <[email protected]>
Signed-off-by: cneben <[email protected]>
Signed-off-by: cneben <[email protected]>
Remove top level QuickContainers directory (not idiomatic for CMake). quickcontainers is now fully integrated in QuickQanava source tree. Signed-off-by: cneben <[email protected]>
Signed-off-by: cneben <[email protected]>
Signed-off-by: cneben <[email protected]>
I think recent master has some of these issues addressed, is that correct? Is this issue here fully covered, or what remains to nicely support modern Qt 6 cmake? |
Well, most of it, but I still maintain qmldir and qrc files + no use of QML_ELEMENT macro. |
Closing for #248 |
The QuickQanava build seems to be implemented before Qt offered the very helpful cmake tooling for QML modules. Much of what the build does manually can now be achieved much nicer with cmake tooling. There would be multiple benefits:
qmltypes
files, which allow the Linterqmllint
to work correctlyqmldir
files is no longer neededFor that, the build should follow https://doc.qt.io/qt-6/qt-query-qml-module.html#example
I can implement this and make a PR if people are interested?
The text was updated successfully, but these errors were encountered: