Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Reduce number of nodes used to store ValueRecords #240

Open
cmyr opened this issue Oct 12, 2023 · 0 comments
Open

Reduce number of nodes used to store ValueRecords #240

cmyr opened this issue Oct 12, 2023 · 0 comments
Labels

Comments

@cmyr
Copy link
Owner

cmyr commented Oct 12, 2023

In doing some simple profiling I noticed that we are allocating a lot of nodes when parsing variable metrics in value records. We're going to need to reduce the amount of nesting here. As illustration, when compiling the variable features for Google Sans, we encounter the following node counts:

VariableMetricNode         59676 
LocationValueNode          477408
LocationSpecNode           477408
LocationSpecItemNode       1432224
AxisLocationNode           1432224

If we can start out by removing AxisLocation and LocationSpecItem that would reduce our allocations by 70%.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant