Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #8282 breaks Rock Paper Scissors #8300

Closed
cm13-issue-bot opened this issue Jan 31, 2025 · 0 comments · Fixed by #8307
Closed

PR #8282 breaks Rock Paper Scissors #8300

cm13-issue-bot opened this issue Jan 31, 2025 · 0 comments · Fixed by #8307
Labels
Bug Admin events aren't bugs

Comments

@cm13-issue-bot
Copy link

Testmerges

#7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit 267636ef4a
#7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit af402858bf
#7650: 'Yet Another Attempt To Fix Vamp' by ihatethisengine at commit eaf54699e6
#8226: 'Project ARES: Turret IFF Controls' by realforest2001 at commit 87114a46ac
#7023: 'Research Rework Part Two: The Contract System.' by kiVts at commit 6e81c9e5e0
#8026: 'Xenomorph Endgame changes' by Git-Nivrak at commit 3c6c29654b
#7320: 'Intel Detector fix' by blackcrystall at commit 5eef44e852
#8281: 'Stat logging improvements' by Zonespace27 at commit 59ae256ed2
#8294: 'Marine Death Tracking' by Zonespace27 at commit 1b40968c7b
#8277: 'Adds a shotgun choke for the M37A2' by VileBeggar at commit b0e2eeb9a4

Round ID

26171

Description of the bug

Attempting to play Rock Paper Scissors will end in a High Five

What's the difference with what should have happened?

Expected: Play Rock Paper Scissors
Result: High Five

How do we reproduce this bug?

  1. Challenge someone to Rock Paper Scissors
  2. Oppenent accepts Rock Paper Scissors challenge and does High Five instead (Either aiming head or any other limb)

Attached logs

N/A

Additional details

  • Author: Vending Machine
  • Admin: NessiePendragon
  • Note: None
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jan 31, 2025
@Zonespace27 Zonespace27 linked a pull request Feb 1, 2025 that will close this issue
Fixes Rock Paper Scissors emotes #8307
Merged
@Drulikar Drulikar mentioned this issue Feb 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 2, 2025
@ihatethisengine
Fixes Rock Paper Scissors emotes (#8307)
f9a7707 
# About the pull request

Fixes: #8300 

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
Bug bad.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Rock Paper Scissors emotes ihatethisengine/cmss13
1 participant
@cm13-issue-bot