Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to use blackmarket #8067

Closed
cm13-issue-bot opened this issue Jan 10, 2025 · 0 comments · Fixed by #8073
Closed

unable to use blackmarket #8067

cm13-issue-bot opened this issue Jan 10, 2025 · 0 comments · Fixed by #8073
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@cm13-issue-bot
Copy link

Testmerges

#7909: 'Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded.' by Watermelon914 at commit f10699e7c0
#7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit 67e1110f23
#7716: 'updates statbrowser stuff' by harryob at commit a457995eb2
#7165: 'Fax Responders TestMerge Collection' by realforest2001 at commit 48de97d337
#7946: 'Resprite of xeno spits and abom action icons' by Blundir at commit 69d62d8b40
#8007: 'Frozen's Rat Competition Reward' by realforest2001 at commit 785b470ab7
#7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit 67a18edc72
#8034: 'reverts #6375' by cuberound at commit 482797ce9c
#8015: 'Mortar Changes' by Git-Nivrak at commit 3a6c587d2d
#7511: 'Weyland-Yutani Intranet Terminal' by realforest2001 at commit babe07fda1
#8049: 'Burn decal burn, hybrisa delaging' by cuberound at commit 0bfd7fcf70

Round ID

25817

Description of the bug

when i try to usse blackmarket it says a fatal exception has occurrred at 002b c562f1b7 in TGUI. Then a bunch of links which I am unable to paste in here

What's the difference with what should have happened?

to open up blackmarket and be able to order things

How do we reproduce this bug?

active the blackmarket and try to use it. you then should not be able to

Attached logs

A fatal exception has occurred at 002B:C562F1B7 in TGUI.The current application will be terminated.Send the copy of the following stack trace to an authorizedWeyland-Yutani incident handler at https://github.com/cmss13-devs/cmss13/issues.Thank you for your cooperation. 
 TypeError: Unable to get property 'map' of undefined or null reference
   at b (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:300:114013)
   at nl (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:65539)
   at gu (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:119140)
   at mu (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:114777)
   at nd (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:114711)
   at gs (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:114564)
   at Sl (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:110776)
   at du (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:111649)
   at aa (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:48522)
   at Anonymous function (https://secure-cdn.cm-ss13.com/live/bf/asset.bf28638c8635e657df61403228f174be.js:9:109168)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"SupplyComputer","window":{"key":"[0x202b510]-main","size":null,"fancy":1,"locked":0}}

Weyland-Yutani (c) 2100-2182 Building better user interfaces. 

Additional details

  • Author: Marko43
  • Admin: SmellyHippie
  • Note: Basically just access the black market then press on any of the selections, it'll crash the UI.
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jan 10, 2025
@LC4492 LC4492 added the Confirmed Bug We have the same at home! label Jan 12, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 13, 2025
# About the pull request

Fixes #8067 
Adds the black market supply packs to the tgui_static_data, which also
prevents a window crash.
Removed a cast from toggle_contraband that was preventing sales to the
black market.

# Explain why it's good for the game

Re-allows use of the black market on the new interface

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>


![ASRS_TGUI_black_market](https://github.com/user-attachments/assets/ff5081eb-b0df-404c-b7c8-373dc90c4b5a)

</details>
Enabled the black market; bought and sold items.

# Changelog

:cl:
fix: Fixes black market TGUI crash
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants