Consumers of Event and Run numbers are not using the proper type

[vlimant]

In many places, some code is extracting the event and run numbers and using it with "random" C++ type instead of using the types defined in

https://github.com/cms-sw/cmssw/blob/master/DataFormats/Provenance/interface/RunLumiEventNumber.h

It actually causes major trouble when the event number goes beyond the casting type (see preshower issue under https://indico.cern.ch/event/1503577/#2-egm-pog-data-vs-mc-compariso).

• As a first step, Ecal will provide a PR for ESDataFormatter and ESDigiToRaw.
• A second step would be to review all packer/unpacker software for such out-of-range casting
• A finale step would be to review all code for such out-of-range casting

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @vlimant.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign EventFilter/ESDigiToRaw

(to start with, please assign further)

[cmsbuild]

New categories assigned: daq

@emeschi,@smorovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

[thomreis]

Fix for ES packer in #47290 . Backports in #47291 , #47292 , #47293, and #47294 .

[thomreis]

The ECAL packer seems to have this issue as well, although it does not seem to lead to zero digis when unpacking as for the ES.

[smorovic]

+daq
yes, signed int event-id, if used, wraps for runs over ~5 hours at 100 kHz

[cmsbuild]

This issue is fully signed and ready to be closed.

[vlimant]

I don't think we can close this issue just yet though

[smorovic]

-daq
to have it pending

[Dr15Jones]

@smuzaffar @makortel So I did a bit of poking around. The standard says the compiler can do integer conversion (e.g. assign the value of an unsigned long long to an int). I did find a gcc warning that can be issued when it is done -Wconversion. Maybe we should turn that one for one IB build?

[smuzaffar]

@Dr15Jones , I have opened cms-sw/cmsdist#9678 to see how many and where we get such conversions

[makortel]

Here is the previous episode in -Wconversion #39098

[thomreis]

The ECAL packer seems to have this issue as well, although it does not seem to lead to zero digis when unpacking as for the ES.

The ECAL packer issue is addressed in #47295 . This one is not as critical as the ES one since not the full event number is used for the packing and the packed bits are not affected.

[smuzaffar]

enabling -Wconversion results in over 500K overall warings https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cad9b/44269/build-logs/ and 26K unique warnings

[Dr15Jones]

@smuzaffar Is there an easy way to get the list of unique warnings?

[smuzaffar]

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cad9b/44269/warnings-unique.txt contains the unique warnings