Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customgrouping 1 is accidently used for SDK value #25

Open
EnessenE opened this issue Sep 28, 2023 · 1 comment
Open

Customgrouping 1 is accidently used for SDK value #25

EnessenE opened this issue Sep 28, 2023 · 1 comment

Comments

@EnessenE
Copy link
Contributor

EnessenE commented Sep 28, 2023 •
edited
Loading

java/blob/master/src/main/java/com/cm/text/models/Message.java#L36
Wrong customgrouping is being used for the text-sdk-java label. This should be customgrouping3 as seen in the dotnet SDK https://github.com/cmdotcom/text-sdk-dotnet/blob/ead36bf5ccbf2ab28586b0f5b27cf216d7c87df3/CM.Text/BusinessMessaging/MessageBuilder.cs#L37
@EnessenE EnessenE mentioned this issue Sep 28, 2023
Closed
@malcos
Copy link

malcos commented Jun 14, 2024 •
edited
Loading

It is nowhere specified what are the default values for those. And using that very same logic, all fields should be empty, no default values should be set if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EnessenE @malcos