Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to em unit #16

Open
adamschwartz opened this issue Feb 17, 2015 · 2 comments
Open

Consider switching to em unit #16

adamschwartz opened this issue Feb 17, 2015 · 2 comments

Comments

@adamschwartz
Copy link

There are a number of advantages to using ems over px. See my identical issue for icono (a similar library) over at saeedalipoor/icono#16.

@cmaddux
Copy link
Owner

cmaddux commented Feb 17, 2015

I've tried out ems for a few of the simpler icons (they're designated scalable on the demo site), but have run into trouble (maybe the rounding problems you mentioned in the icon issues) with the more complex icons. I'm not sure my use of ems is the most efficient, so perhaps cleaning up how I use them will help. I also didn't do a great job of maintaining uniformity in those early icons, which may be contributing to my problems in improving scalability as well. I think there's a way to do it, I just need to spend some time with it. I'll make sure to take a full look at the issue on icono, but if you have any suggestions, just let me know! Thanks again!

@adamschwartz
Copy link
Author

Yeah, it’s definitely tricky. At Eager we use single element icons in our App Store.

I whipped up a little jsFiddle with some of the icons we use and show how they can be rendered at various sizes. No doubt some of your more ambitions icons will make scaling tough, in part due to rounding, and in part due to the way browsers scale the rasterization of various properties (border-radius, adjoining of two-different-sized border-widths, box-shadow, etc.) But maybe this demo will help with your implementation! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants