From ecaf49a6b3105e2de45d053254b6ae751035dd55 Mon Sep 17 00:00:00 2001
From: dyoshikawa <dyoshikawa1993@gmail.com>
Date: Tue, 18 Jan 2022 19:49:34 +0900
Subject: [PATCH] id and ready

---
 README.md                                 | 4 ++--
 packages/niseliff-sdk/src/index.ts        | 8 ++++++--
 packages/niseliff-sdk/src/method/id.ts    | 3 +++
 packages/niseliff-sdk/src/method/ready.ts | 6 ++++++
 4 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 packages/niseliff-sdk/src/method/id.ts
 create mode 100644 packages/niseliff-sdk/src/method/ready.ts

diff --git a/README.md b/README.md
index e55a769..5b5d376 100644
--- a/README.md
+++ b/README.md
@@ -68,8 +68,8 @@ niseliff
 
 ### Features
 
-- [ ] [Ready](https://developers.line.biz/ja/reference/liff/#ready)
-- [ ] [Id](https://developers.line.biz/ja/reference/liff/#id)
+- [x] [Ready](https://developers.line.biz/ja/reference/liff/#ready)
+- [x] [Id](https://developers.line.biz/ja/reference/liff/#id)
 - [x] [Initialize liff app](https://developers.line.biz/ja/reference/liff/#initialize-liff-app)
 - [x] [Get os](https://developers.line.biz/ja/reference/liff/#get-os)
 - [x] [Get language](https://developers.line.biz/ja/reference/liff/#get-language)
diff --git a/packages/niseliff-sdk/src/index.ts b/packages/niseliff-sdk/src/index.ts
index 8f6de9e..eb535b5 100644
--- a/packages/niseliff-sdk/src/index.ts
+++ b/packages/niseliff-sdk/src/index.ts
@@ -12,6 +12,7 @@ import { buildGetLineVersion } from './method/get-line-version'
 import { buildGetOs } from './method/get-os'
 import { buildGetProfile } from './method/get-profile'
 import { buildGetVersion } from './method/get-version'
+import { buildId } from './method/id'
 import { buildInit } from './method/init'
 import { buildInitPlugins } from './method/init-plugins'
 import { buildIsApiAvailable } from './method/is-api-available'
@@ -25,6 +26,7 @@ import { buildPermanentCreateUrlBy } from './method/permanent-link-create-url-by
 import { buildPermanentLinkSetExtraQueryParam } from './method/permanent-link-set-extra-query-param'
 import { buildPermissionQuery } from './method/permission-query'
 import { buildPermissionRequestAll } from './method/permission-request-all'
+import { buildReady } from './method/ready'
 import { buildScanCode } from './method/scan-code'
 import { buildScanCodeV2 } from './method/scan-code-v2'
 import { buildSendMessages } from './method/send-messages'
@@ -34,6 +36,7 @@ import { ConsoleLogger, Logger } from './util/logger'
 export const buildNiseLiff = (params?: {
   clientEndpoint?: string
   authEndpoint?: string
+  liffId?: string
   os?: 'ios' | 'android' | 'web' | undefined
   language?: string
   version?: string
@@ -47,8 +50,6 @@ export const buildNiseLiff = (params?: {
   | 'subWindow'
   | 'isSubWindow'
   | 'use'
-  | 'ready'
-  | 'id'
   | '_dispatchEvent'
   | '_call'
   | '_addListener'
@@ -58,6 +59,7 @@ export const buildNiseLiff = (params?: {
   const logger: Logger = new ConsoleLogger()
   const clientEndpoint = params?.clientEndpoint ?? window.location.origin
   const authEndpoint = params?.authEndpoint ?? 'http://localhost:3000'
+  const liffId = params?.liffId ?? 'DEFAULT_LIFF_ID'
   const os = params?.os ?? 'web'
   const language = params?.language ?? 'ja'
   const version = params?.version ?? '2.16.1'
@@ -65,6 +67,8 @@ export const buildNiseLiff = (params?: {
   const isInClient = params?.isInClient ?? false
 
   return {
+    id: buildId(liffId),
+    ready: buildReady(),
     init: buildInit({ logger, clientEndpoint, authEndpoint }),
     getOS: buildGetOs(os),
     getLanguage: buildGetLanguage(language),
diff --git a/packages/niseliff-sdk/src/method/id.ts b/packages/niseliff-sdk/src/method/id.ts
new file mode 100644
index 0000000..2ca4e16
--- /dev/null
+++ b/packages/niseliff-sdk/src/method/id.ts
@@ -0,0 +1,3 @@
+import liff from '@line/liff'
+
+export const buildId = (liffId: string): typeof liff.id => liffId
diff --git a/packages/niseliff-sdk/src/method/ready.ts b/packages/niseliff-sdk/src/method/ready.ts
new file mode 100644
index 0000000..60afb17
--- /dev/null
+++ b/packages/niseliff-sdk/src/method/ready.ts
@@ -0,0 +1,6 @@
+import liff from '@line/liff'
+
+export const buildReady = (): typeof liff.ready =>
+  new Promise((resolve) => {
+    resolve()
+  })