Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump common version to v2 #64

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

calvin0327
Copy link
Collaborator

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

@clusterpedia-bot
Copy link

Hi @calvin0327,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@calvin0327
Copy link
Collaborator Author

There is test results:

Postgresql:

helm install clusterpedia -n test --create-namespace ./charts/clusterpedia/ --set persistenceMatchNode=None --set postgresql.primary.persistence.enabled=false --debug
image

Mysql:

helm install clusterpedia -n test --create-namespace ./charts/clusterpedia/ --set persistenceMatchNode=None --set mysql.primary.persistence.enabled=false --debug
image

@calvin0327
Copy link
Collaborator Author

@Iceber PTAL

@Iceber
Copy link
Member

Iceber commented Nov 13, 2023

Why upgrade to v2.0?
common is a core dependency of clusterpedia and affects the user's values settings, so to ensure that it doesn't cause incompatible changes for users, and to ensure that users can fix some of the issues on v1
ref pr: bitnami/charts#11830

Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@27149chen
Copy link
Contributor

LGTM, Thanks

@Iceber Iceber merged commit d65f4a3 into clusterpedia-io:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants