Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashing is inconsistent #721

Open
kwalcock opened this issue Mar 4, 2023 · 2 comments
Open

Hashing is inconsistent #721

kwalcock opened this issue Mar 4, 2023 · 2 comments

Comments

@kwalcock
Copy link
Member

kwalcock commented Mar 4, 2023

Sometimes mixLast is used and sometimes it isn't.
@kwalcock
Copy link
Member Author

kwalcock commented Mar 4, 2023

Also, both class org.clulab.odin.Mention has argumentsHashCode() and org.clulab.odin.serialization.json has argsHash() which probably shouldn't be duplicated.

@kwalcock
Copy link
Member Author

kwalcock commented Mar 4, 2023

These aren't being changed just now because that would complicate regression testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwalcock