Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[structure] separate framework from benchmark (from games?) / make pip installable #62

Open
davidschlangen opened this issue Feb 29, 2024 · 1 comment

Comments

@davidschlangen
Copy link
Contributor

Separate (in the repository) the code for the clemgame framework, and for the games.

Besides being more aesthetically pleasing, this would also make it possible to make the framework pip installable.

What needs to be discussed is if further divisions would be possible. One could imagine that even games that are part of the benchmark need not live in the same repository. ... Actually, maybe not. While there can of course be games that live in their own repository (and cli.py should be able to run them), it would probably be too much of a hassle to ensure consistent runs of the benchmark if the code for the constituent games would need to come from several repositories.

So, just two repositories: one for the framework (with everything that's needed to make it pip installable), one for the benchmark.

@Gnurro
Copy link
Collaborator

Gnurro commented Mar 1, 2024

I think it's too early to split things up - mainly due to the fact that the games side of clembench is not much of a framework, at least to me. I expect a framework to handle clearly defined specifications (in this case of games) in a concise format, which do not have or need arbitrary code. Currently almost every clemgame does things very differently in terms of code, and there's no clear way to how to do even that, not to mention any unified way to define clemgames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants