Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction forwarding from replicas to the leader should occur through another internal RPC endpoint instead of eth_sendRawTransaction. #1528

Open
arthurmm-cloudwalk opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working metrics metrics related

Comments

@arthurmm-cloudwalk
Copy link
Contributor

arthurmm-cloudwalk commented Jul 24, 2024

  • Inflated metrics. Today, each transaction that arrives at a replica generates two eth_sendRawTransaction metrics. 1k requests in production are merely replicas forwarding to the leader.

  • Passing the client's request from the replica to the leader. Today, all these requests arrive as stratus in the client instead of having the original client, which impacts traceability.

  • Error handling. Any error from the leader is interpreted as an internal error by the replica. In this scenario, the replica should simply pass on the leader's response without needing to interpret anything.

  • Performance. Decoding the RLP payload of the transaction twice is slow, especially the part of calculating the transaction signer.

@arthurmm-cloudwalk arthurmm-cloudwalk self-assigned this Jul 24, 2024
@arthurmm-cloudwalk arthurmm-cloudwalk added bug Something isn't working metrics metrics related labels Jul 24, 2024
@arthurmm-cloudwalk arthurmm-cloudwalk changed the title Inflated metrics. Foward transactions are being counted twice (follower and leader) Transaction forwarding from replicas to the leader should occur through another internal RPC endpoint instead of eth_sendRawTransaction. Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics metrics related
Projects
None yet
Development

No branches or pull requests

1 participant