Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP errors should be returned by cshark #9

Open
thomasp11 opened this issue Nov 9, 2021 · 2 comments
Open

HTTP errors should be returned by cshark #9

thomasp11 opened this issue Nov 9, 2021 · 2 comments

Comments

@thomasp11
Copy link
Member

If there is any issue during the upload where CloudShark returns a non 200 OK response the cshark plugin returns a generic message back to the client:

cshark/src/uclient.c

Lines 44 to 51 in c0d32fb

static void cshark_header_done_cb(struct uclient *ucl)
{
if (ucl->status_code != 200) {
ERROR("%s: received error, please double check your config file\n", PROJECT_NAME);
uclient_disconnect(ucl);
uloop_end();
}
}

static void cshark_header_done_cb(struct uclient *ucl)
{
	if (ucl->status_code != 200) {
		ERROR("%s: received error, please double check your config file\n", PROJECT_NAME);
		uclient_disconnect(ucl);
		uloop_end();
	}
}

This should also return the error code and message sent by the CloudShark server to the client.

@zaphod-pab
Copy link

Thanks Tom, for the quick reaction to my support request. Much appreciated.

@zaphod-pab
Copy link

Thanks Tom, for the quick reaction to my support request. Much appreciated.

On the other hand, seeing this is a duplicate to issue #4 from 2015 my hopes are fading somewhat ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants