Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional route tables routes creation #32

Closed
wants to merge 3 commits into from
Closed

feat: optional route tables routes creation #32

wants to merge 3 commits into from

Conversation

vshynkar-rew
Copy link

what

  • With this feature, you will be able to specify whether create routes in the route table.

why

  • our company has the network policies which allow you only to create the peering connections, but the route part they want to control by hand.

@vshynkar-rew vshynkar-rew requested review from a team as code owners February 11, 2021 10:33
@vshynkar-rew vshynkar-rew requested a review from a team as a code owner February 11, 2021 10:33
@vshynkar-rew vshynkar-rew requested review from dotCipher and joe-niland and removed request for a team February 11, 2021 10:33
@vshynkar-rew vshynkar-rew changed the title Nice network policy feat: optional route tables routes creation Feb 11, 2021
@sjmiller609
Copy link

This is also valid for the use case if you want to do a peering but only route a subset of the subnets within each VPC

@mergify
Copy link

mergify bot commented Nov 20, 2021

This pull request is now in conflict. Could you fix it @vshynkar-rew? 🙏

@hans-d hans-d added the stale This PR has gone stale label Mar 8, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @vshynkar-rew? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot closed this Mar 9, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Thanks @vshynkar-rew for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwenz723 jwenz723 jwenz723 approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vshynkar-rew @sjmiller609 @jwenz723 @hans-d @cloudpossebot