Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSelectedModels to return models selected on different pageable pages.... #4

Merged
merged 2 commits into from
Dec 19, 2013
Merged

getSelectedModels to return models selected on different pageable pages.... #4

merged 2 commits into from
Dec 19, 2013

Conversation

twalker
Copy link
Contributor

@twalker twalker commented Sep 14, 2013

... fixes#3.

@twalker
Copy link
Contributor Author

twalker commented Sep 14, 2013

This is for #3

Now getSelectedModels supports selections across pages. It makes me wonder if a clearSelectedModels should exist when that's not the desired behavior. But that's another discussion.

wyuenho added a commit that referenced this pull request Dec 19, 2013
@wyuenho
Merge pull request #4 from twalker/master
dda0e28 
getSelectedModels to return models selected on different pageable pages....
@wyuenho wyuenho merged commit dda0e28 into cloudflarearchive:master Dec 19, 2013
@wyuenho wyuenho mentioned this pull request Dec 19, 2013
Closed
@wyuenho
Copy link
Contributor

wyuenho commented Dec 19, 2013

Thank you. Sorry for the delay. This is an excellent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSelectedModels sometimes includes undefined values
2 participants
@twalker @wyuenho