Change notes and mentions of node compat v2 #19079
Merged
+8
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToriLindsay
requested review from
irvinebroque,
a team,
GregBrimble,
mikenomitch,
WalshyDev,
mchenco,
celso and
meddulla
as code owners
github-actions
bot
added
size/s
product:browser-rendering
product:workers
penalosa
approved these changes
Jan 8, 2025
ToriLindsay
commented
Jan 9, 2025
vicb
reviewed
Jan 10, 2025
| ::: | ||
|
|
||
| import { WranglerConfig } from "~/components"; | ||
| <Render file="nodejs-compat-howto" /> |
There was a problem hiding this comment.
Maybe try <Render file="nodejs-compat-howto" product="workers" /> as this is where the partial lives
vicb
approved these changes
Jan 10, 2025
ToriLindsay
commented
Jan 10, 2025
Deploying cloudflare-docs with
|
| Latest commit: |
c5dbdd0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac1afa19.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tori-18773-nodejs-compat-v2.cloudflare-docs-7ou.pages.dev |
petebacondarwin
approved these changes
Jan 10, 2025
Oxyjun
reviewed
Jan 10, 2025
| @@ -214,7 +214,7 @@ minify = true | |||
| watch_dir = "public" | |||
| ``` | |||
|
|
|||
| The `nodejs_compat_v2` flag enables runtime compatibility features required by the OG image generation library, even when using Bun. While we're using Bun as our development runtime, this flag ensures all necessary APIs are available in the Workers environment. The `assets` configuration maps your Worker's public directory, allowing direct access to static files like fonts, images, and favicons through URL paths (for example, `/fonts/Inter.ttf`, `/images/logo.png`). | |||
| [The `nodejs_compat` flag](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag) enables runtime compatibility features required by the OG image generation library, even when using Bun. While we're using Bun as our development runtime, this flag ensures all necessary APIs are available in the Workers environment. The `assets` configuration maps your Worker's public directory, allowing direct access to static files like fonts, images, and favicons through URL paths (for example, `/fonts/Inter.ttf`, `/images/logo.png`). | |||
There was a problem hiding this comment.
Suggested change
| [The `nodejs_compat` flag](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag) enables runtime compatibility features required by the OG image generation library, even when using Bun. While we're using Bun as our development runtime, this flag ensures all necessary APIs are available in the Workers environment. The `assets` configuration maps your Worker's public directory, allowing direct access to static files like fonts, images, and favicons through URL paths (for example, `/fonts/Inter.ttf`, `/images/logo.png`). | |
| [The `nodejs_compat` flag](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag) enables runtime compatibility features required by the OG image generation library, even when using Bun. While we are using Bun as our development runtime, this flag ensures all necessary APIs are available in the Workers environment. The `assets` configuration maps your Worker's public directory, allowing direct access to static files like fonts, images, and favicons through URL paths (for example, `/fonts/Inter.ttf`, `/images/logo.png`). |
Oxyjun
reviewed
Jan 10, 2025
|
|
||
|
|
||
| To use Node.js APIs in your Worker, add the [`nodejs_compat_v2` compatibility flag](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag) to your `wrangler.toml` file. | ||
| To enable built-in Node.js APIs and polyfills, add the nodejs_compat compatibility flag to your `wrangler.toml`. This also enables nodejs_compat_v2 as long as your compatibility date is 2024-09-23 or later. [Learn more about the Node.js compatibility flag and v2](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag). |
There was a problem hiding this comment.
Suggested change
| To enable built-in Node.js APIs and polyfills, add the nodejs_compat compatibility flag to your `wrangler.toml`. This also enables nodejs_compat_v2 as long as your compatibility date is 2024-09-23 or later. [Learn more about the Node.js compatibility flag and v2](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag). | |
| To enable built-in Node.js APIs and polyfills, add the `nodejs_compat` compatibility flag to your `wrangler.toml`. This also enables `nodejs_compat_v2` as long as your compatibility date is 2024-09-23 or later. [Learn more about the Node.js compatibility flag and v2](/workers/configuration/compatibility-flags/#nodejs-compatibility-flag). |
Oxyjun
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18773