Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Repo Setting] Require approval for all external contributors #75

Closed
rswrz opened this issue Dec 13, 2024 · 2 comments · Fixed by #84
Closed

[GitHub Repo Setting] Require approval for all external contributors #75

rswrz opened this issue Dec 13, 2024 · 2 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request security-fix Important security related fix

Comments

@rswrz
Copy link
Member

rswrz commented Dec 13, 2024

I have set "Approval for running fork pull request workflows from contributors" to "Require approval for all external contributors" in our https://github.com/cloudeteer/terraform-azurerm-vm repository. This should be our default for all repositories.

Screenshot

Image

@rswrz rswrz added enhancement New feature or request security-fix Important security related fix labels Dec 13, 2024
@rswrz
Copy link
Member Author

rswrz commented Jan 16, 2025

Unfortunately, this setting cannot be configured via the API, and therefore, is not supported by the Terraform GitHub provider. The solution is to update the repository creation documentation accordingly.

@rswrz
Copy link
Member Author

rswrz commented Jan 16, 2025

I manually set these settings on all existing terraform-* repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security-fix Important security related fix
Projects
None yet
1 participant