Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project contribution #48

Open
diyor28 opened this issue Mar 29, 2022 · 11 comments
Open

Project contribution #48

diyor28 opened this issue Mar 29, 2022 · 11 comments

Comments

@diyor28
Copy link

diyor28 commented Mar 29, 2022

Hi, I use django-rql on daily basis and I would like to contribute to the project. Please let me know what I can work on

@maxipavlovic
Copy link
Member

maxipavlovic commented Apr 1, 2022

@diyor28 great to hear that! Just for our curiosity, would you like to share your use cases?

About contribution, thank you for the intention! Currently, we are in the process of creation of CLA for individual contributors, and I will ping you when we are done.

By the way, you can check CloudBlue vacancies here, if you are interested in contributing from the inside :)

@diyor28
Copy link
Author

diyor28 commented Apr 10, 2022

Sorry for the late reply, missed the notification. Thank you for the invitation to work at CloudBlue! Unfortunately, I'm already an Epam employee.

Regarding the use cases, I usually use it for my personal projects where I need to build a flexible API for a dashboard or admin panel with Django, Django Rest Framework, and Postgres as the backend. The way I found django-rql is quite interesting. I was working with feathersjs, Feathers-Vuex and I loved the flexiable and versatile query language that feathersjs provides, so I wanted to find a similar tool for django. And my search lead me to django-rql.

By the way, I created a typescript version of javascript-rql, since my contribution issue was ignored for some reason. You can check it out here. I would love this to be a part of javascript-rql.

Also I am building vuex-rql(npm: https://www.npmjs.com/package/vuex-rql), an API wrapper for Vuex Store. I will attach a link to npm package once I publish it

@maxipavlovic
Copy link
Member

Thx for the explanation! Will keep in mind featherjs.

Couldn't check TS version as https://github.com/diyor28/js-rql from npm page leads to 404.

Sorry to hear about missing your issue.
@borzovplus @AntonHinz please, help here cloudblue/javascript-rql#10 :)

@diyor28
Copy link
Author

diyor28 commented Apr 10, 2022

My bad, https://github.com/diyor28/js-rql is now a valid repo.

@diyor28
Copy link
Author

diyor28 commented Apr 10, 2022

Regarding django-rql for python, I noticed that it does not support querying by ForeignKey directly or it might just be that I missed it in the docs

@maxipavlovic
Copy link
Member

You mean something like this?

class Model:
  group = FK()

class Filters:
  MODEL = Model
  FILTERS = (
    {
        'filter': 'group.id',
        'source': 'group_id',
    },

I guess, that it's a great note for index optimization purposes, which is not supported at this moment.

@diyor28
Copy link
Author

diyor28 commented Apr 11, 2022

Yeah, exactly. I believe it is a quite common use case where you might need to query records belonging to a certain user. I would love to bring support for that.

@maxipavlovic
Copy link
Member

@diyor28 CLA is ready and integrated. Waiting for your contributions :)

@diyor28
Copy link
Author

diyor28 commented Apr 25, 2022

@maxipavlovic Happy to hear that! What part of it do you think I could start with?

@maxipavlovic
Copy link
Member

Let's start with direct support of FKs as you proposed :)

@diyor28
Copy link
Author

diyor28 commented May 14, 2022

@maxipavlovic Hi, I would love to bring support for that, but I am incredibly busy right now. As soon as I get a few hours of free time I will get to work on this. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants