Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --to implementation and wrong documented --from? #80

Open
MichaelHirn opened this issue Jan 21, 2016 · 2 comments
Open

Missing --to implementation and wrong documented --from? #80

MichaelHirn opened this issue Jan 21, 2016 · 2 comments

Comments

@MichaelHirn
Copy link

I wanted to create a CHANGELOG for a repo, that already had some history and releases - thankfully the commits were all in the same style. Let's assume the repo already had two releases: 0.1.0 and 0.2.0.

So I expcted, that after the execution of the following commands, I would have a CHANGELOG file with the correct history.

clog --setversion 0.1.0 --from 123 --to 456 -C CHANGELOG.md
clog --setversion 0.2.0 --from 456 --to 789 -C CHANGELOG.md

As the docu stated --from and --to assume a commit hash. But after frustation of why clog didn't found the commit hash, I looked into the code and found, that --from works only with a version tag - which it then did. But for --to neither a version tag nor a commit hash worked and I couldn't find any actual implementation for that CLI option, either.

amandasaurus pushed a commit to amandasaurus/clog-cli that referenced this issue Mar 11, 2016
@amandasaurus
Copy link
Contributor

I have made a pull request (#86) which fixes this. However IME it does support commits as well as tags for --from, and now --to. From looking at the clog-lib source code, it looks like it just passes the version string straight to the git command (see here), which according to the docs should work with tags and commit hashes.

@kbknapp
Copy link
Member

kbknapp commented Apr 4, 2016

@rory your commit has been merged with #87

@MichaelHirn does that fix the issue, or should this remain open for other fixes as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants