Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books results from NLB API may have missing values #160

Open
cliffchew84 opened this issue Oct 18, 2024 · 2 comments
Open

Books results from NLB API may have missing values #160

cliffchew84 opened this issue Oct 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cliffchew84
Copy link
Owner

Description:
Some results from SearchTitle and GetTitles may not return all expected data. This includes results with no title or no author. Although this does not cause the app to crash, it causes the user's saved books to have blanks, which is a weird user experience.

Possible next steps:

  1. Capture which APIs may return missing when they occur
  2. Either consider a logic to exclude them from being shown at search or being saved into the user's saved books.
@cliffchew84 cliffchew84 added the bug Something isn't working label Oct 18, 2024
@kiritowu
Copy link
Collaborator

kiritowu commented Dec 9, 2024

Currently when a user visits an unavailable resource, they will be shown a 404 page. But if they like a book on the /search page, the button will just dont work.

Ideally a message pop-up should appear to warn the user that "book is unavailable".

Again, this issue of "phantom" book causes a huge UX issue and needs to be addressed one way or another.

@kiritowu
Copy link
Collaborator

Added toast status raise any error if found for better user interaction
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants