Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose numberOfRecords via REST API (search results) #72

Closed
Querela opened this issue May 23, 2023 · 3 comments
Closed

Expose numberOfRecords via REST API (search results) #72

Querela opened this issue May 23, 2023 · 3 comments
Assignees

Comments

@Querela
Copy link
Contributor

Querela commented May 23, 2023

Idea:
Expose the numberOfRecords SRU searchRetrieve field in the REST API for search results.

Why:
This would allow the frontend to better handle loading more results for single resources. I.e. resources that have already sent all their resources would not show this option to the user that in the end will only show that the endpoint can not provide more results (while this information already exists in the initial search response).

Concerns:

  1. Endpoints might not always correctly set this field. Maybe due to not knowing how many results that can provide in total beforehand (result set might grow?).
    Solution: show button to force request more results with hint that all results should already be present. For FCS 2.0 there is already a field resultCountPrecision that should help with interpreting the numberOfRecords field but once again this can still be misconfigured.
@Querela Querela self-assigned this May 23, 2023
@Querela
Copy link
Contributor Author

Querela commented May 23, 2023

Related: clarin-eric/fcs-sru-client#1

@Querela
Copy link
Contributor Author

Querela commented Jun 16, 2023

See commit: 621a8b7

@Querela
Copy link
Contributor Author

Querela commented Oct 28, 2024

Integrated since 3.6.3.

Not visible in UI yet. But in alternative frontend UI in TPPSSI it is integrated.

@Querela Querela closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant