You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I plan to do a PR for #19, but it the mean time i'm using the conversion features from moneyPHP directly.
The issue is that they return a Money\Money object, which breaks the downstream type hints for \Cknow\Money\Money.
I propose to add a static constructor that returns an instance of this library's class from the base money object. That way, I can massage it back to the right type :)
I plan to do a PR for #19, but it the mean time i'm using the conversion features from moneyPHP directly.
The issue is that they return a
Money\Money
object, which breaks the downstream type hints for\Cknow\Money\Money
.I propose to add a static constructor that returns an instance of this library's class from the base money object. That way, I can massage it back to the right type :)
Will PR shortly if that's ok :)
The text was updated successfully, but these errors were encountered: