Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI builds don't pass with master branch anymore #102

Open
jacksonllee opened this issue Feb 12, 2020 · 3 comments
Open

Travis CI builds don't pass with master branch anymore #102

jacksonllee opened this issue Feb 12, 2020 · 3 comments
Labels

Comments

@jacksonllee
Copy link
Contributor

jacksonllee commented Feb 12, 2020

Curiously, the master branch (updated about two months ago) has had the builds all passed, while the exact same code now apparently cannot pass the builds. The test failures are due to two estimator checks (autoencoder and MLP classifier) not passed. The environments (packages, etc.) should be identical between two months and this week, but maybe there's something we've overlooked.

I came across this while investigating why the builds didn't pass at #101.

@timball
Copy link
Contributor

timball commented Mar 17, 2020

any updates on this? would really like to get that tensorflow security PR merged in.

#101

--timball

@salilgupta1
Copy link

Hey @timball I'll take a look at this issue.

@mheilman mheilman mentioned this issue Apr 3, 2020
@mheilman
Copy link
Contributor

mheilman commented Apr 6, 2020

#103 fixed the build, but I think we should leave this open since I fixed it by skipping part of scikit-learn's check_estimator function (see the PR for details). It'd be nice to solve that in a cleaner way eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants