Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bulma v1.0? $table-cell-border undefined variable #22

Open
hedyhli opened this issue May 19, 2024 · 3 comments
Open

Support Bulma v1.0? $table-cell-border undefined variable #22

hedyhli opened this issue May 19, 2024 · 3 comments

Comments

@hedyhli
Copy link

hedyhli commented May 19, 2024

Hello, I really appreciate you making this plugin to make freezing columns and headers easier for Bulma tables.

I tried using it through npm install + @import with SCSS, and I'm getting:

[plugin:vite:css] [sass] Undefined variable.
   ╷
22 │       border: $table-cell-border;
   │               ^^^^^^^^^^^^^^^^^^
   ╵
  node_modules/.pnpm/@[email protected]/node_modules/@cityssm/bulma-sticky-table/_sticky-table.scss 22:15  root stylesheet
/Users/hedy/projects/indecisive-solid/node_modules/.pnpm/@[email protected]/node_modules/@cityssm/bulma-sticky-table/_sticky-table.scss:22:15

I'm using Bulma v1 here. I noticed the repo hasn't been updated since last year, and Bulma v1 might've been released after the last update, so perhaps this is a Bulma v1 incompatibility issue here?

Thanks!

@dangowans
Copy link
Member

You hit the nail on the head @hedyhli .

Bulma v1 changed a lot of variable names, unfortunately making it incompatible with quite a few of our Bulma-related packages. Hoping to get to this at some point.

dangowans added a commit that referenced this issue May 21, 2024
@dangowans
Copy link
Member

I was able to get the CSS to compile with Bulma v1. Not sure about the look and feel though. Some of the table styles changed in v1.

@dangowans
Copy link
Member

The Bulma v1 version has been published to npm as v3.0.0. Hopefully it will solved your issue.

https://github.com/cityssm/bulma-sticky-table/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants